From: Wolfram Sang <wsa@kernel.org>
To: Jan Dabros <jsd@semihalf.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, hdegoede@redhat.com,
rrangel@chromium.org, mw@semihalf.com, jaz@semihalf.com,
upstream@semihalf.com, thomas.lendacky@amd.com,
alexander.deucher@amd.com, Nimesh.Easow@amd.com,
mario.limonciello@amd.com
Subject: Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support
Date: Thu, 10 Feb 2022 23:09:23 +0100 [thread overview]
Message-ID: <YgWNE05eVK+LijL/@kunai> (raw)
In-Reply-To: <20220208141218.2049591-3-jsd@semihalf.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:
> Implement an I2C controller sharing mechanism between the host (kernel)
> and PSP co-processor on some platforms equipped with AMD Cezanne SoC.
>
> On these platforms we need to implement "software" i2c arbitration.
> Default arbitration owner is PSP and kernel asks for acquire as well
> as inform about release of the i2c bus via mailbox mechanism.
>
> +---------+
> <- ACQUIRE | |
> +---------| CPU |\
> | | | \ +----------+ SDA
Applied to for-next, thanks! I fixed the following checkpatch warnings:
CHECK: Please don't use multiple blank lines
#232: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:92:
+
+
WARNING: braces {} are not necessary for single statement blocks
#361: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:221:
+ if (ret) {
+ goto cleanup;
+ }
Please also use checkpatch next time.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-10 22:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 14:12 [PATCH v4 0/2] i2c-designware: Add support for AMD PSP semaphore Jan Dabros
2022-02-08 14:12 ` [PATCH v4 1/2] i2c: designware: Add missing locks Jan Dabros
2022-02-09 15:01 ` Jarkko Nikula
2022-02-09 15:23 ` Andy Shevchenko
2022-02-10 22:08 ` Wolfram Sang
2022-02-10 23:05 ` Jan Dąbroś
2022-02-08 14:12 ` [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support Jan Dabros
2022-02-09 15:27 ` Andy Shevchenko
2022-02-10 8:18 ` Jan Dąbroś
2022-02-10 14:43 ` Jarkko Nikula
2022-02-10 15:04 ` Jan Dąbroś
2022-02-10 22:09 ` Wolfram Sang [this message]
2022-02-10 23:05 ` Jan Dąbroś
2022-02-11 9:56 ` Wolfram Sang
2022-02-09 15:11 ` [PATCH v4 0/2] i2c-designware: Add support for AMD PSP semaphore Jarkko Nikula
2022-02-10 8:13 ` Jan Dąbroś
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgWNE05eVK+LijL/@kunai \
--to=wsa@kernel.org \
--cc=Nimesh.Easow@amd.com \
--cc=alexander.deucher@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jaz@semihalf.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mw@semihalf.com \
--cc=rrangel@chromium.org \
--cc=thomas.lendacky@amd.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox