From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Rob Herring <robh@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] dt-bindings: rtc: pcf2127: add PCF2131 INT_A and INT_B support
Date: Thu, 10 Feb 2022 23:32:32 +0100 [thread overview]
Message-ID: <YgWSgGTKR63g+S9e@piout.net> (raw)
In-Reply-To: <20220210171234.4e317c8a5d5f91f358382b07@hugovil.com>
On 10/02/2022 17:12:34-0500, Hugo Villeneuve wrote:
> On Tue, 8 Feb 2022 21:20:28 -0600
> Rob Herring <robh@kernel.org> wrote:
>
> > On Tue, Jan 25, 2022 at 03:00:09PM -0500, Hugo Villeneuve wrote:
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >
> > > The PCF2131 has two output interrupt pins, named INT_A and INT_B.
> > >
> > > Add properties to identify onto which pin we want the alarm interrupt
> > > to be routed. It can be either one, or both.
> > >
> > > These properties are automatically set to false for variants other
> > > than PCF2131 (ex: PCF2127).
> > >
> > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > ---
> > > .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 23 +++++++++++++++++++
> > > 1 file changed, 23 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > index 57eb0a58afa3..83656dd2f97f 100644
> > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > @@ -24,6 +24,16 @@ properties:
> > > interrupts:
> > > maxItems: 1
> > >
> > > + alarm-output-a:
> >
> > nxp,alarm-output-a
>
> Ok, this will be fixed for V2.
>
Actually, this property has to be made more generic and thought out.
There are multiple RTCs that have multiple interrupt pins where one of
the pin can be used for different interrupt or clock output.
With your binding, there is no way to separate which interrupt is going
to which pin and so there is no way to get the alarm and BLF or the
watchdog on different pins and we certainly don't want to have a
property per interrupt type.
Also, the documentation is missing the fact that the driver makes having
one of the property mandatory.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-02-10 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220125200009.900660-1-hugo@hugovil.com>
2022-01-25 20:00 ` [PATCH 01/10] rtc: pcf2127: add variant-specific configuration structure Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 02/10] rtc: pcf2127: adapt for time/date registers at any offset Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 03/10] rtc: pcf2127: adapt for alarm " Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 04/10] rtc: pcf2127: adapt for WD " Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 05/10] rtc: pcf2127: adapt for CLKOUT register " Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 06/10] rtc: pcf2127: add support for multiple TS functions Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 07/10] rtc: pcf2127: add support for PCF2131 RTC Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 08/10] rtc: pcf2127: add support for PCF2131 alarm interrupt on outputs INT_A/B Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 09/10] dt-bindings: rtc: pcf2127: add PCF2131 Hugo Villeneuve
2022-02-09 3:23 ` Rob Herring
2022-01-25 20:00 ` [PATCH 10/10] dt-bindings: rtc: pcf2127: add PCF2131 INT_A and INT_B support Hugo Villeneuve
2022-02-09 3:20 ` Rob Herring
2022-02-10 22:12 ` Hugo Villeneuve
2022-02-10 22:32 ` Alexandre Belloni [this message]
2022-02-10 22:55 ` Hugo Villeneuve
2022-02-11 20:16 ` Hugo Villeneuve
2022-02-11 21:02 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgWSgGTKR63g+S9e@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox