Re: [PATCH net-next v2 2/2] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers

Rob Herring
2022-02-09T15:39:18Z

On Wed, Feb 9, 2022 at 9:35 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, 09 Feb 2022 09:10:25 +0100, Oleksij Rempel wrote:
> > Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
> > import all currently supported USB IDs form drivers/net/usb/smsc95xx.c
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > .../bindings/net/microchip,lan95xx.yaml | 80 +++++++++++++++++++
> > 1 file changed, 80 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1590223
>
>
> smsc@2: $nodename:0: 'smsc@2' does not match '^ethernet(@.*)?$'
> arch/arm/boot/dts/tegra30-ouya.dt.yaml
>
> usbether@1: $nodename:0: 'usbether@1' does not match '^ethernet(@.*)?$'
> arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dt.yaml
> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dt.yaml
> arch/arm/boot/dts/bcm2835-rpi-b.dt.yaml
> arch/arm/boot/dts/bcm2835-rpi-b-plus.dt.yaml
> arch/arm/boot/dts/bcm2835-rpi-b-rev2.dt.yaml
> arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
> arch/arm/boot/dts/bcm2837-rpi-3-b.dt.yaml
> arch/arm/boot/dts/omap3-beagle-xm-ab.dt.yaml
> arch/arm/boot/dts/omap3-beagle-xm.dt.yaml
> arch/arm/boot/dts/omap4-panda-a4.dt.yaml
> arch/arm/boot/dts/omap4-panda.dt.yaml
> arch/arm/boot/dts/omap4-panda-es.dt.yaml
>
> usbether@3: $nodename:0: 'usbether@3' does not match '^ethernet(@.*)?$'
> arch/arm/boot/dts/omap5-uevm.dt.yaml

So this binding is already in use, but was undocumented? Or did you
forget to remove the .txt file? The commit message should highlight
all this.

(I don't expect you to fix all these warnings, I was just surprised to
see them given this is an 'initial schema'.)

Rob