From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9FBC433F5 for ; Sat, 12 Feb 2022 16:47:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237566AbiBLQrr (ORCPT ); Sat, 12 Feb 2022 11:47:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237543AbiBLQrn (ORCPT ); Sat, 12 Feb 2022 11:47:43 -0500 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340A05FEA for ; Sat, 12 Feb 2022 08:47:38 -0800 (PST) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 21CGkxsP010096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 12 Feb 2022 11:47:00 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1847215C0040; Sat, 12 Feb 2022 11:46:59 -0500 (EST) Date: Sat, 12 Feb 2022 11:46:59 -0500 From: "Theodore Ts'o" To: Qing Wang Cc: Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Michael Turquette , Stephen Boyd , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Dmitry Torokhov , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Mauro Carvalho Chehab , Hans Verkuil , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment Message-ID: References: <1644546640-23283-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote: > From: Wang Qing > > It is better to use time_is_xxx() directly instead of jiffies judgment > for understanding. Hi Wang, "judgement" doesn't really make sense as a description to an English speaker. The following a commit desription (for all of these series) is probably going to be a bit more understable: Use the helper function time_is_{before,after}_jiffies() to improve code readability. Cheers, - Ted