From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nuno Sá" <nuno.sa@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages
Date: Mon, 14 Feb 2022 11:23:44 +0200 [thread overview]
Message-ID: <YgofoEOPuiB4LbQT@smile.fi.intel.com> (raw)
In-Reply-To: <20220213175559.46e8dee2@jic23-huawei>
On Sun, Feb 13, 2022 at 05:55:59PM +0000, Jonathan Cameron wrote:
> On Thu, 10 Feb 2022 15:55:20 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > In a couple of messages the constants, which have their definitions,
> > are hard coded into the message text. Unhardcode them.
> >
> > While at it, add a trailing \n where it's currently missing.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>
> Mostly so I can remember what is going on with this patch,
> Nuno is OoO and planning to test this series when he returns.
>
> Given that I'll wait on Nuno's testing.
Me too :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-02-14 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 13:55 [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Andy Shevchenko
2022-02-10 13:55 ` [PATCH v3 2/3] iio: temperature: ltc2983: Use single error path to put OF node Andy Shevchenko
2022-02-10 13:55 ` [PATCH v3 3/3] iio: temperature: ltc2983: Make use of device properties Andy Shevchenko
2022-03-03 13:31 ` Sa, Nuno
2022-03-03 13:57 ` Andy Shevchenko
2022-03-03 14:53 ` Sa, Nuno
2022-03-03 14:23 ` Andy Shevchenko
2022-03-03 14:27 ` Andy Shevchenko
2022-03-03 14:52 ` Sa, Nuno
2022-02-13 17:55 ` [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Jonathan Cameron
2022-02-14 9:23 ` Andy Shevchenko [this message]
2022-03-02 15:50 ` Andy Shevchenko
2022-03-02 19:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgofoEOPuiB4LbQT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox