Re: [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

Lee Jones
2022-02-09T19:25:39Z

On Wed, 09 Feb 2022, Matthew Wilcox wrote:

> On Wed, Feb 09, 2022 at 03:59:48PM +0000, Lee Jones wrote:
> > On Wed, 09 Feb 2022, Christoph Hellwig wrote:
> >
> > > On Wed, Feb 09, 2022 at 08:52:43AM +0000, Lee Jones wrote:
> > > > This reverts commit 60263d5889e6dc5987dc51b801be4955ff2e4aa7.
> > > >
> > > > Reverting since this commit opens a potential avenue for abuse.
> > > >
> > > > The C-reproducer and more information can be found at the link below.
> > > >
> > > > With this patch applied, I can no longer get the repro to trigger.
> > >
> > > Well, maybe you should actually debug and try to understand what is
> > > going on before blindly reverting random commits.
> >
> > That is not a reasonable suggestion.
> >
> > Requesting that someone becomes an area expert on a huge and complex
> > subject such as file systems (various) in order to fix your broken
> > code is not rational.
>
> Sending a patch to revert a change you don't understand is also
> not rational. If you've bisected it to a single change -- great!
> If reverting the patch still fixes the bug -- also great! But
> don't send a patch when you clearly don't understand what the
> patch did.

If reverting isn't the correct thing to do here, please consider this
as a bug report.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog