From: Joerg Roedel <joro@8bytes.org>
To: David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Will Deacon <will@kernel.org>,
~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/msm: simplify with dev_err_probe()
Date: Mon, 14 Feb 2022 14:21:09 +0100 [thread overview]
Message-ID: <YgpXRQ9KJrgJ+Cwc@8bytes.org> (raw)
In-Reply-To: <20220206202945.465195-1-david@ixit.cz>
On Sun, Feb 06, 2022 at 09:29:45PM +0100, David Heidelberg wrote:
> Use the dev_err_probe() helper to simplify error handling during probe.
> This also handle scenario, when EDEFER is returned and useless error is
> printed.
>
> Fixes warnings as:
> msm_iommu 7500000.iommu: could not get smmu_pclk
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> drivers/iommu/msm_iommu.c | 24 ++++++++++--------------
> 1 file changed, 10 insertions(+), 14 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2022-02-14 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 20:29 [PATCH] iommu/msm: simplify with dev_err_probe() David Heidelberg
2022-02-14 13:21 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgpXRQ9KJrgJ+Cwc@8bytes.org \
--to=joro@8bytes.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox