Re: [PATCH 06/12] KVM: MMU: rename kvm_mmu_reload

Sean Christopherson
2022-02-11T00:27:41Z

On Wed, Feb 09, 2022, Paolo Bonzini wrote:
> The name of kvm_mmu_reload is very confusing for two reasons:
> first, KVM_REQ_MMU_RELOAD actually does not call it; second,
> it only does anything if there is no valid root.
>
> Rename it to kvm_mmu_ensure_valid_root, which matches the actual
> behavior better.

100% agree that kvm_mmu_reload() is a terrible name, but kvm_mmu_ensure_valid_root()
isn't much better, e.g. it sounds like a sanity check and nothing more.

Maybe just be very literalal?

kvm_mmu_load_if_necessary()
kvm_mmu_load_if_invalid()

Or follow cond_sched()?

kvm_mmu_cond_load()