From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andre Kalb <andre.kalb@sma.de>
Cc: pmladek@suse.com, john.ogness@linutronix.de,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
senozhatsky@chromium.org
Subject: Re: [PATCH v2] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user_specified == true
Date: Tue, 15 Feb 2022 12:15:58 +0900 [thread overview]
Message-ID: <Ygsa7gfqlhZVWdDb@google.com> (raw)
In-Reply-To: <YgpXWQqjfJBISG1v@pc6682>
On (22/02/14 14:21), Andre Kalb wrote:
> +static void set_user_specified(struct console_cmdline *c, bool user_specified)
> +{
> + if (!user_specified)
> + return;
> +
> + c->user_specified = true;
> + console_set_on_cmdline = 1;
> +}
In original code we always set c->user_specified. Is it guaranteed that
->user_specified is properly initialized to 0? Maybe can do something like:
static void set_user_specified(struct console_cmdline *c, bool user_specified)
{
c->user_specified = user_specified;
if (!user_specified)
return;
console_set_on_cmdline = 1;
}
next prev parent reply other threads:[~2022-02-15 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 23:00 [PATCH] printk: Set console_set_on_cmdline=1 when using console="" or console=null Andre Kalb
2022-02-08 15:55 ` Petr Mladek
2022-02-14 13:21 ` [PATCH v2] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user_specified == true Andre Kalb
2022-02-15 3:15 ` Sergey Senozhatsky [this message]
2022-02-15 17:58 ` Petr Mladek
2022-02-15 18:10 ` Petr Mladek
2022-02-16 3:18 ` Sergey Senozhatsky
2022-02-16 10:41 ` [PATCH v3] " Andre Kalb
2022-02-21 15:49 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygsa7gfqlhZVWdDb@google.com \
--to=senozhatsky@chromium.org \
--cc=andre.kalb@sma.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox