From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Andre Kalb <andre.kalb@sma.de>,
john.ogness@linutronix.de, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, senozhatsky@chromium.org
Subject: Re: [PATCH v2] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user_specified == true
Date: Wed, 16 Feb 2022 12:18:49 +0900 [thread overview]
Message-ID: <YgxtGWh0b9NXTyu8@google.com> (raw)
In-Reply-To: <YgvsqldT1sjfF5lf@alley>
On (22/02/15 19:10), Petr Mladek wrote:
[..]
> We should add a comment explaining the less obvious behavior as
> discussed in the thread. Something like:
>
> > +static void set_user_specified(struct console_cmdline *c, bool user_specified)
> > +{
> > + if (!user_specified)
> > + return;
> > +
> /*
> * @c console was defined by the user on the command line.
> * Do not clear when added twice also by SPCR or the device tree.
> */
> > + c->user_specified = true;
> /* At least one console defined by the user on the command line. */
> > + console_set_on_cmdline = 1;
> > +}
> > +
> > static int __add_preferred_console(char *name, int idx, char *options,
> > char *brl_options, bool user_specified)
> > {
>
> With the above comments:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Sergey, is it enough from your POV, please?
Yes, Petr. Thank you.
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
next prev parent reply other threads:[~2022-02-16 3:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 23:00 [PATCH] printk: Set console_set_on_cmdline=1 when using console="" or console=null Andre Kalb
2022-02-08 15:55 ` Petr Mladek
2022-02-14 13:21 ` [PATCH v2] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user_specified == true Andre Kalb
2022-02-15 3:15 ` Sergey Senozhatsky
2022-02-15 17:58 ` Petr Mladek
2022-02-15 18:10 ` Petr Mladek
2022-02-16 3:18 ` Sergey Senozhatsky [this message]
2022-02-16 10:41 ` [PATCH v3] " Andre Kalb
2022-02-21 15:49 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgxtGWh0b9NXTyu8@google.com \
--to=senozhatsky@chromium.org \
--cc=andre.kalb@sma.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox