Re: [PATCH v2] printk: Set console_set_on_cmdline=1 when __add_preferred_console() is called with user_specified == true

Sergey Senozhatsky
2022-02-16T03:18:58Z

On (22/02/15 19:10), Petr Mladek wrote:
[..]
> We should add a comment explaining the less obvious behavior as
> discussed in the thread. Something like:
>
> > +static void set_user_specified(struct console_cmdline *c, bool user_specified)
> > +{
> > + if (!user_specified)
> > + return;
> > +
> /*
> * @c console was defined by the user on the command line.
> * Do not clear when added twice also by SPCR or the device tree.
> */
> > + c->user_specified = true;
> /* At least one console defined by the user on the command line. */
> > + console_set_on_cmdline = 1;
> > +}
> > +
> > static int __add_preferred_console(char *name, int idx, char *options,
> > char *brl_options, bool user_specified)
> > {
>
> With the above comments:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Sergey, is it enough from your POV, please?

Yes, Petr. Thank you.

Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>