From: Catalin Marinas <catalin.marinas@arm.com>
To: David Engraf <david.engraf@sysgo.com>
Cc: suzuki.poulose@arm.com, will@kernel.org, broonie@kernel.org,
mark.rutland@arm.com, elver@google.com, ebiederm@xmission.com,
seanjc@google.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: signal: nofpsimd: Do not allocate fp/simd context when not available
Date: Mon, 28 Feb 2022 18:34:46 +0000 [thread overview]
Message-ID: <Yh0VxizGmOFHVqL3@arm.com> (raw)
In-Reply-To: <20220225104008.820289-1-david.engraf@sysgo.com>
On Fri, Feb 25, 2022 at 11:40:08AM +0100, David Engraf wrote:
> Commit 6d502b6ba1b2 ("arm64: signal: nofpsimd: Handle fp/simd context for
> signal frames") introduced saving the fp/simd context for signal handling
> only when support is available. But setup_sigframe_layout() always
> reserves memory for fp/simd context. The additional memory is not touched
> because preserve_fpsimd_context() is not called and thus the magic is
> invalid.
>
> This may lead to an error when parse_user_sigframe() checks the fp/simd
> area and does not find a valid magic number.
>
> Signed-off-by: David Engraf <david.engraf@sysgo.com>
Given that it's not a regression, I wouldn't push it at -rc7. But if
Will picks it up for 5.18, I think it's worth adding:
Fixes: 6d502b6ba1b2 ("arm64: signal: nofpsimd: Handle fp/simd context for signal frames")
Cc: <stable@vger.kernel.org> # 5.6.x
With that:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2022-02-28 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 10:40 [PATCH] arm64: signal: nofpsimd: Do not allocate fp/simd context when not available David Engraf
2022-02-25 17:57 ` Mark Brown
2022-02-28 7:56 ` David Engraf
2022-02-28 13:20 ` Mark Brown
2022-02-28 18:34 ` Catalin Marinas [this message]
2022-03-07 22:03 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh0VxizGmOFHVqL3@arm.com \
--to=catalin.marinas@arm.com \
--cc=broonie@kernel.org \
--cc=david.engraf@sysgo.com \
--cc=ebiederm@xmission.com \
--cc=elver@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox