* [PATCH] Asoc: au1x: Use devm_snd_soc_register_component()
@ 2022-03-01 9:23 Zhen Ni
2022-03-01 13:28 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Ni @ 2022-03-01 9:23 UTC (permalink / raw)
To: lgirdwood, broonie, tiwai; +Cc: alsa-devel, linux-kernel, Zhen Ni
Using devm_snd_soc_register_component()
instead of snd_soc_register_component()
Signed-off-by: Zhen Ni <nizhen@uniontech.com>
---
sound/soc/au1x/ac97c.c | 2 +-
sound/soc/au1x/i2sc.c | 2 +-
sound/soc/au1x/psc-ac97.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/au1x/ac97c.c b/sound/soc/au1x/ac97c.c
index 3b1700e665f5..795bba756585 100644
--- a/sound/soc/au1x/ac97c.c
+++ b/sound/soc/au1x/ac97c.c
@@ -275,7 +275,7 @@ static int au1xac97c_drvprobe(struct platform_device *pdev)
if (ret)
return ret;
- ret = snd_soc_register_component(&pdev->dev, &au1xac97c_component,
+ ret = devm_snd_soc_register_component(&pdev->dev, &au1xac97c_component,
&au1xac97c_dai_driver, 1);
if (ret)
return ret;
diff --git a/sound/soc/au1x/i2sc.c b/sound/soc/au1x/i2sc.c
index 740d4e052e4d..a3c9d52ef337 100644
--- a/sound/soc/au1x/i2sc.c
+++ b/sound/soc/au1x/i2sc.c
@@ -265,7 +265,7 @@ static int au1xi2s_drvprobe(struct platform_device *pdev)
platform_set_drvdata(pdev, ctx);
- return snd_soc_register_component(&pdev->dev, &au1xi2s_component,
+ return devm_snd_soc_register_component(&pdev->dev, &au1xi2s_component,
&au1xi2s_dai_driver, 1);
}
diff --git a/sound/soc/au1x/psc-ac97.c b/sound/soc/au1x/psc-ac97.c
index 05eb36991f14..3f60313822e7 100644
--- a/sound/soc/au1x/psc-ac97.c
+++ b/sound/soc/au1x/psc-ac97.c
@@ -411,7 +411,7 @@ static int au1xpsc_ac97_drvprobe(struct platform_device *pdev)
if (ret)
return ret;
- ret = snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
+ ret = devm_snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
&wd->dai_drv, 1);
if (ret)
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Asoc: au1x: Use devm_snd_soc_register_component()
2022-03-01 9:23 [PATCH] Asoc: au1x: Use devm_snd_soc_register_component() Zhen Ni
@ 2022-03-01 13:28 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-03-01 13:28 UTC (permalink / raw)
To: Zhen Ni; +Cc: lgirdwood, tiwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
On Tue, Mar 01, 2022 at 05:23:22PM +0800, Zhen Ni wrote:
> +++ b/sound/soc/au1x/psc-ac97.c
> @@ -411,7 +411,7 @@ static int au1xpsc_ac97_drvprobe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - ret = snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
> + ret = devm_snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
> &wd->dai_drv, 1);
> if (ret)
> return ret;
> --
This introduces a double free since there is a remove() function which
calls snd_soc_unregister_component().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-01 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-01 9:23 [PATCH] Asoc: au1x: Use devm_snd_soc_register_component() Zhen Ni
2022-03-01 13:28 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox