From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9570C433F5 for ; Tue, 1 Mar 2022 23:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbiCAXXt (ORCPT ); Tue, 1 Mar 2022 18:23:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbiCAXXr (ORCPT ); Tue, 1 Mar 2022 18:23:47 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9815E26579 for ; Tue, 1 Mar 2022 15:23:04 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id i5so248659oih.1 for ; Tue, 01 Mar 2022 15:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B0gHl0FY6TKEqOe5dLt6k+4Sn54m7FTDQTv9BgJSJmY=; b=w0vaAwCSOgyqV35VqOvdvCY5g5lLUapGsVPxGHCUGkyNVEZZ6/kdXXdorDxIWT537G MUzstVRDZ3xYnf+Y9IFCbWdyvIkckOkma3wtDXYzlDYyytWeVjj9Odjlj5+D9r8fwvj2 HBlTjilOI+nEJdz3FhwuFG3VKC9KGwVOZ7O2hrV6heTO5iRov7z0PDXH3z4BPlRzYKTv 5/jrfCYiWgnu5huDJykK1R+/WVA38iPh2c4glxVQ1n0YucaZOGhzKvcC+t97UFVrBEib t7csV3GYm681yeV9UhUvLQCbzuULjwq6xD1qPDdr/pvZDlEKMFcqLg3bq07rx6Y7Y6Ia G1fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B0gHl0FY6TKEqOe5dLt6k+4Sn54m7FTDQTv9BgJSJmY=; b=CRf++1ER2Zb36Mpzemin4BCcRJMhpkYSg0Mx0Bs9FDPVOcmjf1GfsOS+e3kBM0zGHM qimAALkq8CdiqZtW3GIShbH38ilYaaSFiGkfsvhcW44mnjjZcAgByGCrBU0vJzaSKsCA eL20BsXF5c8IbJYm10UOsX+rE5GvAvrSY4JhXwqry8JV9rolCJX3hqt5oV9Lm8WK4zup ssx/QPX2Dk7ueBvX2b44e6kL1W7g4+J4InRI58oEq/YUuCUcRGQZ7UADhmWZKEploriU I4xOrWeDAyorhlw5hLKzqsV1QDsdmIYlnkRDKsno2z0hmP1CgW9mJvXDjbsns/s0ID8q hrNw== X-Gm-Message-State: AOAM530Xl34F95BQ/1OUdNE+sKeD3/+fI7ZrUGOoR5aZLCxEP3RBRzvw 9NQAs++0Ot0uwdXP8ezHJpU1XQ== X-Google-Smtp-Source: ABdhPJxEJ64Gn/cTmYTu3qBhsOi969AzEkmMsQpBT2a/tPl/ZeLLMLvf5SzTIPzDYBU8Q9JQ6K3z1w== X-Received: by 2002:a05:6808:1183:b0:2d4:5eeb:1ca3 with SMTP id j3-20020a056808118300b002d45eeb1ca3mr14925434oil.8.1646176983843; Tue, 01 Mar 2022 15:23:03 -0800 (PST) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id 16-20020a9d0490000000b005ad3c83e927sm7091173otm.60.2022.03.01.15.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 15:23:03 -0800 (PST) Date: Tue, 1 Mar 2022 15:24:54 -0800 From: Bjorn Andersson To: Pavel Machek Cc: Uwe Kleine-K?nig , Thierry Reding , Lee Jones , Rob Herring , Jonathan Corbet , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Luca Weiss , Doug Anderson Subject: Re: [PATCH v13 2/2] leds: Add driver for Qualcomm LPG Message-ID: References: <20220218183116.2261770-1-bjorn.andersson@linaro.org> <20220218183116.2261770-2-bjorn.andersson@linaro.org> <20220224165939.4275x7mzp7qpl2kj@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224165939.4275x7mzp7qpl2kj@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 24 Feb 08:59 PST 2022, Uwe Kleine-K?nig wrote: > On Fri, Feb 18, 2022 at 10:31:16AM -0800, Bjorn Andersson wrote: [..] > > diff --git a/Documentation/leds/leds-qcom-lpg.rst b/Documentation/leds/leds-qcom-lpg.rst [..] > > +Simple pattern:: > > + > > + "255 500 0 500" > > + > > + ^ > > + | > > + 255 +----+ +----+ > > + | | | | ... > > + 0 | +----+ +---- > > + +----------------------> > > + 0 5 10 15 time (100ms) > > you're mixing tabs and spaces here, I suggest to use spaces only. Not > sure you want to respin for that. > > (I didn't look into the rest of the driver, but assume it's fine.) > Pavel, would yo like me to fix this up and send out v14 or would you be okay replacing the tab with spaces while applying the patches? Do you see any other blockers for merging this? Thanks, Bjorn