From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072C2C433EF for ; Wed, 2 Mar 2022 03:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239259AbiCBDO5 (ORCPT ); Tue, 1 Mar 2022 22:14:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231449AbiCBDOx (ORCPT ); Tue, 1 Mar 2022 22:14:53 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1E7BAEF16; Tue, 1 Mar 2022 19:14:11 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id r7so430348iot.3; Tue, 01 Mar 2022 19:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iYcFqXZ3f+3vaLrLlPHVjivEfeCZxjhL/C8gZ+zIprU=; b=kYULTdoHBl9943ttJvK8zc3511heUc9zNOHTLC8o/fXVmSh0hiXNvNQYREC75HRZGU fCKLhnnHbKXJ0+TFl8zRlQkCEzPf4mDwhsBJrNhV8JvkrKY1HtHAi92x24BOZbVDeZnA W+BoDdN2NB6y8AjJZSmywm7bBuxiuthfwb5bLiBkg4SOfZ/IVASG1nsqD+Vsn8IJQspo dQmrwJEg+QMGKDLduCpVT4hjNPYPhDJZZg+tefF813dY/YqKQguuNwgBlmmgGO0/bn4s aCaZwjVFJ4IDBW6rrEQcI1HfXMcr2BwyP+Af/FaFf/OMwKCGHFrkwsByPqEzZuihB7/o Z99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iYcFqXZ3f+3vaLrLlPHVjivEfeCZxjhL/C8gZ+zIprU=; b=6/KL71UM1tWCZwkEapkUxbZBWHg3dVzwoEuI+vxggmVkWgG4uD4d23VOJnsY8vA+qh FoxhuFg0WhhkXyzunCH2AqJq4trS5tjWh6biR3cFVWRzpBi6JDJwQ0uQy2K8UpcdvIj7 kLiEl5FlMc8qxgMn/cBdQPVTxA9L6/ZOdrK8QTXdxk4p25Q7z0cuG67AJ1LVCTumu2VM s2Ce1JrRMVxnod/G1GUdqam09Y6Tyuxs9BNv6Er3m8KPb4aO1K7NHZ97y/HdUgcItOW4 h3aDgRwUhWn9YDLDBZhvAL/X+zkB69s5GgXesG8u4btvsRbo4PrEpiTuIrygS+0kGKCo 1Z7w== X-Gm-Message-State: AOAM532Zn6JEuI0eXPXpR9R0nKsddBZuc77B/Ethf5DkJ+WxlOA1o1q7 wBORYxzi8a2mWIGopH4xZsM= X-Google-Smtp-Source: ABdhPJw05AvAfdvmaxRyIyts0b9CxLZQXZOgSNW87dIDgLcUFsaKeKi9cU0QZp6THIK0IyZPkHZWjA== X-Received: by 2002:a05:6638:502:b0:30e:4b0c:55cf with SMTP id i2-20020a056638050200b0030e4b0c55cfmr23313828jar.11.1646190851140; Tue, 01 Mar 2022 19:14:11 -0800 (PST) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id s12-20020a92cbcc000000b002bd04428740sm8832499ilq.80.2022.03.01.19.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 19:14:09 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id CA1F627C0054; Tue, 1 Mar 2022 22:14:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 01 Mar 2022 22:14:08 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtfedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhquhhn ucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrth htvghrnhepvdelieegudfggeevjefhjeevueevieetjeeikedvgfejfeduheefhffggedv geejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsg hoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieeg qddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigi hmvgdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Mar 2022 22:14:07 -0500 (EST) Date: Wed, 2 Mar 2022 11:13:05 +0800 From: Boqun Feng To: Wei Liu Cc: "Michael Kelley (LINUX)" , Lorenzo Pieralisi , Sunil Muthuswamy , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Dexuan Cui , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , "linux-hyperv@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH v2] PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64 Message-ID: References: <20220217034525.1687678-1-boqun.feng@gmail.com> <20220221175600.gxbphsnbytgytcpz@liuwe-devbox-debian-v2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221175600.gxbphsnbytgytcpz@liuwe-devbox-debian-v2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022 at 05:56:00PM +0000, Wei Liu wrote: > On Thu, Feb 17, 2022 at 04:31:06PM +0000, Michael Kelley (LINUX) wrote: > > From: Boqun Feng Sent: Wednesday, February 16, 2022 7:45 PM > > > > > > On ARM64 Hyper-V guests, SPIs are used for the interrupts of virtual PCI > > > devices, and SPIs can be managed directly via GICD registers. Therefore > > > the retarget interrupt hypercall is not needed on ARM64. > > > > > > An arch-specific interface hv_arch_irq_unmask() is introduced to handle > > > the architecture level differences on this. For x86, the behavior > > > remains unchanged, while for ARM64 no hypercall is invoked when > > > unmasking an irq for virtual PCI devices. > > > > > > Signed-off-by: Boqun Feng > > > --- > > > v1 -> v2: > > > > > > * Introduce arch-specific interface hv_arch_irq_unmask() as > > > suggested by Bjorn > > > > > > drivers/pci/controller/pci-hyperv.c | 233 +++++++++++++++------------- > > > 1 file changed, 122 insertions(+), 111 deletions(-) > > > > Reviewed-by: Michael Kelley > > I expect this to go through the PCI tree. Let me know if I should pick > this up. > I also expect the same. Lorenzo, let me know if there is more work needed for this patch. Thanks! Regards, Boqun > Thanks, > Wei.