Re: [PATCH v2 03/18] KVM: x86/mmu: WARN if PAE roots linger after kvm_mmu_unload

Maxim Levitsky
2022-02-23T14:11:16Z

On Fri, 2022-02-18 at 18:23 +0100, Paolo Bonzini wrote:
> On 2/18/22 18:14, Sean Christopherson wrote:
> > Checkpatch doesn't like it, and IMO the existing asserts
> > are unnecessary.
>
> I agree that removing the assertions could be another way to go.
>
> A third and better one could be to just wait until pae_root is gone. I
> have started looking at it but I would like your opinion on one detail;
> see question I posted at
> https://lore.kernel.org/kvm/7ccb16e5-579e-b3d9-cedc-305152ef9b8f@redhat.com/.
>
> For now I'll drop this patch.

IMHO, the idea of having shadow pages backing the synthetic pages like pae roots,
is a very good idea.

I hope I get to review that RFC very soon.

Best regards,
Maxim Levitsky

>
> Paolo
>