From: Eric Biggers <ebiggers@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v2 04/10] random: group initialization wait functions
Date: Sun, 20 Feb 2022 20:49:14 -0800 [thread overview]
Message-ID: <YhMZyrF2jkXRwA/D@sol.localdomain> (raw)
In-Reply-To: <20220212122318.623435-5-Jason@zx2c4.com>
On Sat, Feb 12, 2022 at 01:23:12PM +0100, Jason A. Donenfeld wrote:
> +/*
> + * Static global variables
> + */
> +static DECLARE_WAIT_QUEUE_HEAD(random_write_wait);
> +static struct fasync_struct *fasync;
> +
> +static int crng_init_cnt = 0;
> +static void _get_random_bytes(void *buf, size_t nbytes);
A couple oddities here:
- 'fasync' is being defined twice. It's already defined earlier in the file.
- The prototype for _get_random_bytes() is unnecessary.
Other than that this patch looks good.
- Eric
next prev parent reply other threads:[~2022-02-21 4:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 12:23 [PATCH v2 00/10] random: re-group and re-document functions Jason A. Donenfeld
2022-02-12 12:23 ` [PATCH v2 01/10] random: introduce drain_entropy() helper to declutter crng_reseed() Jason A. Donenfeld
2022-02-21 4:34 ` Eric Biggers
2022-02-21 14:49 ` Jason A. Donenfeld
2022-02-21 14:49 ` [PATCH v3] " Jason A. Donenfeld
2022-02-21 19:19 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 02/10] random: remove useless header comment Jason A. Donenfeld
2022-02-21 4:34 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 03/10] random: remove whitespace and reorder includes Jason A. Donenfeld
2022-02-21 4:35 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 04/10] random: group initialization wait functions Jason A. Donenfeld
2022-02-13 6:54 ` Dominik Brodowski
2022-02-13 13:11 ` Jason A. Donenfeld
2022-02-21 4:49 ` Eric Biggers [this message]
2022-02-21 15:10 ` Jason A. Donenfeld
2022-02-21 15:14 ` [PATCH v3] " Jason A. Donenfeld
2022-02-21 19:20 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 05/10] random: group crng functions Jason A. Donenfeld
2022-02-13 6:54 ` Dominik Brodowski
2022-02-13 13:14 ` Jason A. Donenfeld
2022-02-21 5:00 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 06/10] random: group entropy extraction functions Jason A. Donenfeld
2022-02-21 5:05 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 07/10] random: group entropy collection functions Jason A. Donenfeld
2022-02-13 6:54 ` Dominik Brodowski
2022-02-13 13:16 ` Jason A. Donenfeld
2022-02-21 5:13 ` Eric Biggers
2022-02-21 15:17 ` Jason A. Donenfeld
2022-02-21 15:18 ` [PATCH v3] " Jason A. Donenfeld
2022-02-21 19:23 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 08/10] random: group userspace read/write functions Jason A. Donenfeld
2022-02-21 5:16 ` Eric Biggers
2022-02-12 12:23 ` [PATCH v2 09/10] random: group sysctl functions Jason A. Donenfeld
2022-02-21 5:21 ` Eric Biggers
2022-02-21 15:27 ` Jason A. Donenfeld
2022-02-21 15:39 ` Jason A. Donenfeld
2022-02-12 12:23 ` [PATCH v2 10/10] random: rewrite header introductory comment Jason A. Donenfeld
2022-02-21 5:26 ` Eric Biggers
2022-02-13 6:55 ` [PATCH v2 00/10] random: re-group and re-document functions Dominik Brodowski
2022-02-13 13:07 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhMZyrF2jkXRwA/D@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox