From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
kernel@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: ttyprintk: register console
Date: Mon, 21 Feb 2022 19:27:04 +0100 [thread overview]
Message-ID: <YhPZeDBlrHjLcgPh@kroah.com> (raw)
In-Reply-To: <20220215141750.92808-1-vincent.whitchurch@axis.com>
On Tue, Feb 15, 2022 at 03:17:49PM +0100, Vincent Whitchurch wrote:
> Register a console in the ttyprintk driver so that it can be selected
> for /dev/console with console=ttyprintk on the kernel command line,
> similar to other console drivers.
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---
> drivers/char/Kconfig | 3 ++-
> drivers/char/ttyprintk.c | 16 ++++++++++++++++
> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 740811893c57..c553a8a50d03 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -18,7 +18,8 @@ config TTY_PRINTK
> The feature is useful to inline user messages with kernel
> messages.
> In order to use this feature, you should output user messages
> - to /dev/ttyprintk or redirect console to this TTY.
> + to /dev/ttyprintk or redirect console to this TTY, or boot
> + the kernel with console=ttyprintk.
Why do you want to use this tty device as a console? What benifit does
that provide?
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-21 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 14:17 [PATCH] char: ttyprintk: register console Vincent Whitchurch
2022-02-21 18:27 ` Greg Kroah-Hartman [this message]
2022-02-24 10:08 ` Vincent Whitchurch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhPZeDBlrHjLcgPh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox