From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA248C433F5 for ; Mon, 21 Feb 2022 18:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231751AbiBUSoA (ORCPT ); Mon, 21 Feb 2022 13:44:00 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:58328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbiBUSmi (ORCPT ); Mon, 21 Feb 2022 13:42:38 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B74D9D97; Mon, 21 Feb 2022 10:42:12 -0800 (PST) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 25BF663580; Mon, 21 Feb 2022 19:41:15 +0100 (CET) Date: Mon, 21 Feb 2022 19:42:09 +0100 From: Pablo Neira Ayuso To: Eric Dumazet Cc: Linus Torvalds , Woody Suwalski , Florian Westphal , Linux Kernel Mailing List , Netdev Subject: Re: Linux 5.17-rc5 Message-ID: References: <8f331927-69d4-e4e7-22bc-c2a2a098dc1e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Alpine 2.23 (DEB 453 2020-06-18) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022 at 10:28:46AM -0800, Eric Dumazet wrote: > On Mon, Feb 21, 2022 at 10:25 AM Pablo Neira Ayuso wrote: > > > > On Mon, Feb 21, 2022 at 10:21:16AM -0800, Eric Dumazet wrote: > > > On Mon, Feb 21, 2022 at 10:08 AM Linus Torvalds > > > wrote: > > > > > > > > On Mon, Feb 21, 2022 at 10:02 AM Eric Dumazet wrote: > > > > > > > > > > I am pretty sure Pablo fixed this one week ago. > > > > > > > > .. looks about right. Apart from the "it was never sent to me, so -rc5 > > > > ended up showing the problem" part. > > > > > > > > > > Indeed, I personally these kinds of trivial fixes should be sent right away, > > > especially considering two bots complained about it. > > > > I did not consider this so important, that was my fault. > > Well, I was the one adding this compile error ;) I poorly performed as a duly reviewer :) > Testing CONFIG_IPV6=n builds is not my top priority. For the record, this patch is now flying to the netdev tree via pull request: https://patchwork.kernel.org/project/netdevbpf/patch/20220221161757.250801-1-pablo@netfilter.org/ Thanks.