Re: [PATCH v2 5/9] random: do not xor RDRAND when writing into /dev/random

Jason A. Donenfeld
2022-02-09T11:49:52Z

On Wed, Feb 9, 2022 at 9:31 AM Dominik Brodowski
<linux@dominikbrodowski.net> wrote:
> Looks good generally, just one unrelated change slipped in:
>
> > bytes = min(count, sizeof(buf));
> > - if (copy_from_user(&buf, p, bytes))
> > + if (copy_from_user(buf, p, bytes))
> > return -EFAULT;

I'll often fix up very minor adjacent code style things. In this case,
`buf` is an array, so the code is equivalent, but I prefer the latter,
which is mostly what's used throughout the driver.

Jason