From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Tyrone Ting <warp5tw@gmail.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, robh+dt@kernel.org,
krzysztof.kozlowski@canonical.com, semen.protsenko@linaro.org,
yangyicong@hisilicon.com, wsa@kernel.org, jie.deng@intel.com,
sven@svenpeter.dev, bence98@sch.bme.hu,
christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com,
olof@lixom.net, arnd@arndb.de, digetx@gmail.com,
andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com,
Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com,
devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/11] i2c: npcm: Remove unused clock node
Date: Tue, 22 Feb 2022 16:58:55 +0100 [thread overview]
Message-ID: <YhUIP4pvoGBUohCE@latitude> (raw)
In-Reply-To: <CACD3sJbMZ-CT4htPUBqyswghAC+j8PgJ_z-VdA38yC+6HFrF+w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Tue, Feb 22, 2022 at 10:15:04AM +0800, Tyrone Ting wrote:
> Hi Jonathan:
>
> Thank you for your comments and please find my reply next to your comments.
>
> Jonathan Neuschäfer <j.neuschaefer@gmx.net> 於 2022年2月21日 週一 下午7:49寫道：
> >
> > On Sun, Feb 20, 2022 at 11:53:15AM +0800, Tyrone Ting wrote:
> > > From: Tali Perry <tali.perry1@gmail.com>
> > >
> > > Remove unused npcm750-clk node.
> >
> > You're not actually removing a node, for example in the sense of removing a
> > devicetree node from a devicetree.
> >
> > So, I think "Remove unused variable clk_regmap." would be a better
> > description.
> >
>
> May I modify the description according to your input and attach
> "Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>"
> onto this commit in the next version of the patch set?
Yes!
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-22 15:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 3:53 [PATCH v2 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 01/11] arm: dts: add new property for NPCM i2c module Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-02-21 2:36 ` Rob Herring
2022-02-21 8:31 ` Tyrone Ting
2022-02-22 17:56 ` Rob Herring
2022-02-23 3:41 ` Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 03/11] i2c: npcm: Fix client address calculation Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 04/11] i2c: npcm: Update gcr property name Tyrone Ting
2022-02-20 9:32 ` Krzysztof Kozlowski
2022-02-21 8:29 ` Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 05/11] i2c: npcm: Remove unused clock node Tyrone Ting
2022-02-21 11:49 ` Jonathan Neuschäfer
2022-02-22 2:15 ` Tyrone Ting
2022-02-22 15:58 ` Jonathan Neuschäfer [this message]
2022-02-23 3:38 ` Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 06/11] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 07/11] i2c: npcm: Add tx complete counter Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 08/11] i2c: npcm: Correct register access width Tyrone Ting
2022-02-21 11:55 ` Jonathan Neuschäfer
2022-02-20 3:53 ` [PATCH v2 09/11] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 10/11] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 11/11] i2c: npcm: Support NPCM845 Tyrone Ting
2022-02-20 9:36 ` Krzysztof Kozlowski
2022-02-21 8:33 ` Tyrone Ting
2022-02-20 9:30 ` [PATCH v2 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Krzysztof Kozlowski
2022-02-21 8:16 ` Tyrone Ting
2022-02-21 8:32 ` Krzysztof Kozlowski
2022-02-21 8:47 ` Tyrone Ting
2022-03-01 19:45 ` Wolfram Sang
2022-03-02 12:53 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhUIP4pvoGBUohCE@latitude \
--to=j.neuschaefer@gmx.net \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=bence98@sch.bme.hu \
--cc=benjaminfair@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jie.deng@intel.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=warp5tw@gmail.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox