Re: [PATCH v2 01/15] dt-bindings: ufs: add common platform bindings

Krzysztof Kozlowski
2022-02-27T10:24:20Z

On 25/02/2022 20:26, Rob Herring wrote:
> On Tue, Feb 22, 2022 at 03:58:40PM +0100, Krzysztof Kozlowski wrote:
>> Add bindings for common parts (platform) of Universal Flash Storage
>> (UFS) Host Controllers in dtschema format.
>>
>> The 'freq-table-hz' is not correct in dtschema, because '-hz' suffix
>> defines uint32 type, not an array. Therefore deprecate 'freq-table-hz'
>> and use 'freq-table' instead.
>
> -hz is an array type. We can extend it to matrix if needed.
>
> I do think this property is a bit questionable. Do we really need a
> minimum in DT and if not, wouldn't assigned-clocks-rate work? Or an OPP
> table.
>

I think the proper solution is OPP table, see also comments from Bjorn:
https://lore.kernel.org/all/YhUodbzxx4wbr+gy@ripper/

I would rather refrain from converting it to OPP tables, because I won't
be able to test any changes in the driver.

Best regards,
Krzysztof