From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0EFC433F5 for ; Wed, 23 Feb 2022 07:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235666AbiBWH11 (ORCPT ); Wed, 23 Feb 2022 02:27:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230206AbiBWH1W (ORCPT ); Wed, 23 Feb 2022 02:27:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5386A4B1D6 for ; Tue, 22 Feb 2022 23:26:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DBB36B81E7E for ; Wed, 23 Feb 2022 07:26:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22C6CC340E7; Wed, 23 Feb 2022 07:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645601210; bh=4aYeprl1yFAaJnrCjzgBXkCQEEGD6c0Oa0Rh1cEsO7g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bs2LFlAJFNJV8mp2EdG1/QyOWCnKF9uOcI9iY5648SPtTnfM/ala6Dj8GOdFjDWlx Y3hL72txQTuOEUoaAgbcynmqX2FF9wbBkpK/vNwLMIPN4nty/n2skrcMEzw5cjqHN/ FLOHpYyipT9u7JmT1O66xSjw+1yxYKzaE3UeEu+U= Date: Wed, 23 Feb 2022 08:26:47 +0100 From: Greg Kroah-Hartman To: Desmond yan Cc: Scott Branden , Arnd Bergmann , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] misc: bcm-vk: add kconfig for supporting viper chip Message-ID: References: <20220218200811.17136-1-desmond.yan@broadcom.com> <534605ef-aeb1-b0a2-2326-be6faba4709c@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <534605ef-aeb1-b0a2-2326-be6faba4709c@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 22, 2022 at 09:14:02PM -0800, Desmond yan wrote: > > Greg, > > Please see inlined. > > On 2/22/22 09:13, Greg Kroah-Hartman wrote: > > A: http://en.wikipedia.org/wiki/Top_post > > Q: Were do I find info about this thing called top-posting? > > A: Because it messes up the order in which people normally read text. > > Q: Why is top-posting such a bad thing? > > A: Top-posting. > > Q: What is the most annoying thing in e-mail? > > > > A: No. > > Q: Should I include quotations after my reply? > > > > > > http://daringfireball.net/2007/07/on_top > > > > On Tue, Feb 22, 2022 at 07:41:04AM -0800, Desmond Yan (APD) wrote: > > > Greg, > > > > > > This is to allow the customer to use their own driver, by default, > > > which is their preferred option. > > > > We do not care about out-of-tree code, and do not add Kconfig options > > just for that, sorry. > > > > Why not just add the out-of-tree driver here to the in-kernel code? > > What is preventing that from happening today? > > Using the bcm_vk driver for viper is only for proof-of-concept, and is not > aimed to be deployed for production. In parallel, customer is developing > their own production-ready driver and would probably upstream it whenever > the appropriate time comes. Ok, so let us not add a new config option only for one person working on writing their own driver. Let's just add the device id as there are more people than just that one person wanting to use their hardware with the existing drivers. Please resubmit this without the Kconfig change and I will be glad to take it. thanks, greg k-h