From: 'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>
To: David Laight <David.Laight@aculab.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Subject: Re: [PATCH v1 1/1] IB/hfi1: Don't cast parameter in bit operations
Date: Thu, 24 Feb 2022 03:00:59 +0200 [thread overview]
Message-ID: <YhbYy7BRAw59V1It@smile.fi.intel.com> (raw)
In-Reply-To: <efb8c82c626a4c7d8a9f781d63289343@AcuMS.aculab.com>
On Wed, Feb 23, 2022 at 10:50:19PM +0000, David Laight wrote:
> From: 'Andy Shevchenko'
> > Sent: 23 February 2022 22:30
> > On Wed, Feb 23, 2022 at 09:44:32PM +0000, David Laight wrote:
> > > From: Andy Shevchenko
> > > > Sent: 23 February 2022 18:54
...
> > Either way it wastes cycles, the outcome depends on the actual distribution of
> > the interrupts across the bitmap. If it gathered closer to the beginning of the
> > bitmap, my code wins, otherwise the original ones.
>
> The loop in bitmap_empty() will kill you - even if the first word in non-zero.
What loop? Did you really look into implementation of bitmap_empty()?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-02-24 1:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 18:53 [PATCH v1 1/1] IB/hfi1: Don't cast parameter in bit operations Andy Shevchenko
2022-02-23 21:44 ` David Laight
2022-02-23 22:30 ` 'Andy Shevchenko'
2022-02-23 22:50 ` David Laight
2022-02-24 1:00 ` 'Andy Shevchenko' [this message]
2022-02-24 13:44 ` Dennis Dalessandro
2022-02-24 13:38 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhbYy7BRAw59V1It@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox