From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] driver core: Refactor sysfs and drv/bus remove hooks
Date: Thu, 24 Feb 2022 10:07:40 +0100 [thread overview]
Message-ID: <YhdK3NtkC0sgkNgO@kroah.com> (raw)
In-Reply-To: <20220223225257.1681968-3-robh@kernel.org>
On Wed, Feb 23, 2022 at 04:52:57PM -0600, Rob Herring wrote:
> There are 3 copies of the same device sysfs cleanup and drv/bus remove()
> hooks used for probe failure, testing re-probing, and device unbinding.
>
> Let's refactor the code to its own function.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Note that driver_sysfs_remove() remains a separate call because in
> __device_release_driver() it is called with a pm runtime get/put and
> before the unbind notifier. Browsing the history, it doesn't seem like
> there's any particular reason for this ordering. We also have other
> sysfs teardown done later. It would be more logical to do all the
> sysfs teardown at once. Thoughts?
I think it should be unified, so you can send a follow-on patch to do
that.
I'll go queue these changes up now, thanks for the cleanups!
greg k-h
next prev parent reply other threads:[~2022-02-24 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 22:52 [PATCH 0/2] driver core: Refactor device unbind/probe fail clean-ups Rob Herring
2022-02-23 22:52 ` [PATCH 1/2] driver core: Refactor multiple copies of device cleanup Rob Herring
2022-02-23 22:52 ` [PATCH 2/2] driver core: Refactor sysfs and drv/bus remove hooks Rob Herring
2022-02-24 9:07 ` Greg Kroah-Hartman [this message]
2022-02-24 9:08 ` [PATCH 0/2] driver core: Refactor device unbind/probe fail clean-ups Greg Kroah-Hartman
2022-02-24 13:24 ` Rob Herring
2022-02-24 18:24 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhdK3NtkC0sgkNgO@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox