[PATCH] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[PATCH] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Prathamesh Shete]

From: Manish Bhardwaj <mbhardwaj@nvidia.com>

Using this patch we are adding PMC compatible string for
Tegra234 in GPIO driver so the irq hierarchy can be set.

Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
---
 drivers/gpio/gpio-tegra186.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index d38980b9923a..c1e9dd8c78f8 100644
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -563,6 +563,7 @@ static unsigned int tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,
 static const struct of_device_id tegra186_pmc_of_match[] = {
 	{ .compatible = "nvidia,tegra186-pmc" },
 	{ .compatible = "nvidia,tegra194-pmc" },
+	{ .compatible = "nvidia,tegra234-pmc" },
 	{ /* sentinel */ }
 };
 
-- 
2.17.1

Re: [PATCH] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

On Thu, Feb 24, 2022 at 01:54:09PM +0530, Prathamesh Shete wrote:
> From: Manish Bhardwaj <mbhardwaj@nvidia.com>
> 
> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the irq hierarchy can be set.

s/irq/IRQ/, but otherwise looks good:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Prathamesh Shete]

Using this patch we are adding PMC compatible string for
Tegra234 in GPIO driver so the IRQ hierarchy can be set.

Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
---
 drivers/gpio/gpio-tegra186.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index 54d9fa7da9c1..824a355ff27a 100644
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -669,6 +669,7 @@ static unsigned int tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,
 static const struct of_device_id tegra186_pmc_of_match[] = {
 	{ .compatible = "nvidia,tegra186-pmc" },
 	{ .compatible = "nvidia,tegra194-pmc" },
+	{ .compatible = "nvidia,tegra234-pmc" },
 	{ /* sentinel */ }
 };
 
-- 
2.17.1

RE: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Prathamesh Shete]

Hi 
Can you please help review this patch 

Thanks
Prathamesh.

> -----Original Message-----
> From: Prathamesh Shete <pshete@nvidia.com>
> Sent: Tuesday, August 16, 2022 3:57 PM
> To: linus.walleij@linaro.org; bgolaszewski@baylibre.com; linux-
> gpio@vger.kernel.org; linux-tegra@vger.kernel.org; linux-
> kernel@vger.kernel.org; Jonathan Hunter <jonathanh@nvidia.com>;
> thierry.reding@gmail.com
> Cc: Suresh Mangipudi <smangipudi@nvidia.com>; Prathamesh Shete
> <pshete@nvidia.com>; Manish Bhardwaj <mbhardwaj@nvidia.com>
> Subject: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO
> driver
> 
> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
> 
> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
>  drivers/gpio/gpio-tegra186.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c index
> 54d9fa7da9c1..824a355ff27a 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -669,6 +669,7 @@ static unsigned int
> tegra186_gpio_child_offset_to_irq(struct gpio_chip *chip,  static const struct
> of_device_id tegra186_pmc_of_match[] = {
>  	{ .compatible = "nvidia,tegra186-pmc" },
>  	{ .compatible = "nvidia,tegra194-pmc" },
> +	{ .compatible = "nvidia,tegra234-pmc" },
>  	{ /* sentinel */ }
>  };
> 
> --
> 2.17.1

Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Linus Walleij]

On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <pshete@nvidia.com> wrote:

> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
>
> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It also has Thierry's ACK from v1.

Yours,
Linus Walleij

Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Jon Hunter]

Hi Linus,

On 08/09/2022 14:21, Linus Walleij wrote:
> On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <pshete@nvidia.com> wrote:
> 
>> Using this patch we are adding PMC compatible string for
>> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
>>
>> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
>> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> It also has Thierry's ACK from v1.
> 
> Yours,
> Linus Walleij


I don't see this one in -next. Are you able to pick this up?

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Linus Walleij]

On Mon, Jan 9, 2023 at 9:37 PM Jon Hunter <jonathanh@nvidia.com> wrote:
> On 08/09/2022 14:21, Linus Walleij wrote:
> > On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <pshete@nvidia.com> wrote:
> >
> >> Using this patch we are adding PMC compatible string for
> >> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
> >>
> >> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
> >> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > It also has Thierry's ACK from v1.
> >
> > Yours,
> > Linus Walleij
>
>
> I don't see this one in -next. Are you able to pick this up?
>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>

Bartosz is queueing GPIO patches right now, but the mail has the
wrong address for him.

I put the new mail address in To, so he can pick it up.

Yours,
Linus Walleij

Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Bartosz Golaszewski]

On Tue, Jan 10, 2023 at 9:24 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Jan 9, 2023 at 9:37 PM Jon Hunter <jonathanh@nvidia.com> wrote:
> > On 08/09/2022 14:21, Linus Walleij wrote:
> > > On Tue, Aug 16, 2022 at 12:27 PM Prathamesh Shete <pshete@nvidia.com> wrote:
> > >
> > >> Using this patch we are adding PMC compatible string for
> > >> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
> > >>
> > >> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
> > >> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> > >
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > >
> > > It also has Thierry's ACK from v1.
> > >
> > > Yours,
> > > Linus Walleij
> >
> >
> > I don't see this one in -next. Are you able to pick this up?
> >
> > Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> > Tested-by: Jon Hunter <jonathanh@nvidia.com>
>
> Bartosz is queueing GPIO patches right now, but the mail has the
> wrong address for him.
>
> I put the new mail address in To, so he can pick it up.
>

Come on, my address changed 18 months ago, re-run get_maintainers.pl
from time to time. :)

Now applied, thanks!

Bart

Re: [PATCH v2] gpio: tegra186: add Tegra234 PMC compatible in GPIO driver

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On Tue, Aug 16, 2022 at 03:57:25PM +0530, Prathamesh Shete wrote:
> Using this patch we are adding PMC compatible string for
> Tegra234 in GPIO driver so the IRQ hierarchy can be set.
> 
> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
>  drivers/gpio/gpio-tegra186.c | 1 +
>  1 file changed, 1 insertion(+)

I already acked this on v1, but here goes again, for patchwork:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]