From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CEE5C433F5 for ; Thu, 24 Feb 2022 15:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235871AbiBXPOq (ORCPT ); Thu, 24 Feb 2022 10:14:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235875AbiBXPOh (ORCPT ); Thu, 24 Feb 2022 10:14:37 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5243E20A950; Thu, 24 Feb 2022 07:14:07 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D63B71EC0528; Thu, 24 Feb 2022 16:14:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1645715642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=nSq5oYXo1UEvyHJYxYxFKGBXBtBsPoV2+wY1jf02ac4=; b=h/WDBZg1kLW1wZiyrreLLv3am4Xhxws3c3qT9/EYQmDXy5LN0d09fkrZKnTJ3rl/KzXr1Z 9YkaCUAgmGjFiEY6Bs5yDLCoz5N0/JK33pvK9ZtbAYKtq/ntgVJ83Aoi6k9idFe/hZ6BnT DSn6dEBIPL95eNvLo3Y588IpplhemCk= Date: Thu, 24 Feb 2022 16:14:05 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Smita Koralahalli , x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "H . Peter Anvin" , Dave Hansen , Yazen Ghannam Subject: Re: [PATCH 1/2] x86/mce: Remove old CMCI storm mitigation code Message-ID: References: <20220217141609.119453-1-Smita.KoralahalliChannabasappa@amd.com> <20220217141609.119453-2-Smita.KoralahalliChannabasappa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 09:35:52AM -0800, Luck, Tony wrote: > When a "storm" of CMCI is detected this code mitigates by > disabling CMCI interrupt signalling from all of the banks > owned by the CPU that saw the storm. > > There are problems with this approach: > > 1) It is very coarse grained. In all liklihood only one of the Unknown word [liklihood] in commit message. Suggestions: ['likelihood', 'livelihood'] > banks was geenrating the interrupts, but CMCI is disabled for all. Unknown word [geenrating] in commit message. Suggestions: ['generating', 'penetrating', 'germinating', 'entreating', 'ingratiating'] Do I need to give you the whole spiel about using a spellchecker? :) > This means Linux may delay seeing and processing errors logged > from other banks. > > 2) Although CMCI stands for Corrected Machine Check Interrupt, it > is also used to signal when an uncorrected error is logged. This > is a problem because these errors should be handled in a timely > manner. > > Delete all this code in preparation for a finer grained solution. > > Signed-off-by: Tony Luck > --- > arch/x86/kernel/cpu/mce/core.c | 20 +--- > arch/x86/kernel/cpu/mce/intel.c | 145 ----------------------------- > arch/x86/kernel/cpu/mce/internal.h | 6 -- > 3 files changed, 1 insertion(+), 170 deletions(-) Yah, can't complain about diffstats like that. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette