Re: [PATCH v3 4/7] clk: qcom: Add A7 PLL support for SDX65

Rohit Agarwal
2022-02-21T07:28:17Z

On 2/21/2022 11:10 AM, Manivannan Sadhasivam wrote:
> On Mon, Feb 21, 2022 at 10:52:30AM +0530, Rohit Agarwal wrote:
>> Add support for PLL found in Qualcomm SDX65 platforms which is used to
>> provide clock to the Cortex A7 CPU via a mux. This PLL can provide high
>> frequency clock to the CPU above 1GHz as compared to the other sources
>> like GPLL0.
>>
>> In this driver, the power domain is attached to the cpudev. This is
>> required for CPUFreq functionality and there seems to be no better place
>> to do other than this driver (no dedicated CPUFreq driver).
>>
> This tells what the driver is doing but not essentially what this patch does
> i.e., you need to mention how the SDX65 PLL is added to the driver. Since you
> are reusing the existing driver, this needs to be mentioned.
Will update.
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>> drivers/clk/qcom/Kconfig | 6 +++---
>> drivers/clk/qcom/a7-pll.c | 1 +
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 42c8741..5159a1d 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -29,11 +29,11 @@ config QCOM_A53PLL
>> devices.
>>
>> config QCOM_A7PLL
>> - tristate "SDX55 A7 PLL"
>> + tristate "A7 PLL driver for SDX55 and SDX65"
>> help
>> - Support for the A7 PLL on SDX55 devices. It provides the CPU with
>> + Support for the A7 PLL on SDX55 and SDX65 devices. It provides the CPU with
>> frequencies above 1GHz.
>> - Say Y if you want to support higher CPU frequencies on SDX55
>> + Say Y if you want to support higher CPU frequencies on SDX55 and SDX65
>> devices.
>>
>> config QCOM_CLK_APCS_MSM8916
>> diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
>> index c4a53e5..adb2121 100644
>> --- a/drivers/clk/qcom/a7-pll.c
>> +++ b/drivers/clk/qcom/a7-pll.c
>> @@ -84,6 +84,7 @@ static int qcom_a7pll_probe(struct platform_device *pdev)
>>
>> static const struct of_device_id qcom_a7pll_match_table[] = {
>> { .compatible = "qcom,sdx55-a7pll" },
>> + { .compatible = "qcom,sdx65-a7pll" },
> I think here also you can just reuse the "qcom,sdx55-a7pll" compatible.
Ok, Will update. Thanks!
>
> Thanks,
> Mani
>
>> { }
>> };
>> MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);
>> --
>> 2.7.4
>>