From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC4CC433F5 for ; Thu, 24 Feb 2022 23:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbiBXXSR (ORCPT ); Thu, 24 Feb 2022 18:18:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbiBXXSP (ORCPT ); Thu, 24 Feb 2022 18:18:15 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A79221B0190 for ; Thu, 24 Feb 2022 15:17:44 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id r187-20020a1c2bc4000000b003810e6b192aso706340wmr.1 for ; Thu, 24 Feb 2022 15:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8/1Ko41seG/Gcm0WMFG2nw3d5RUz09+SdFfLxzqmI+Y=; b=3KjdLrszxDrpmXCBbrp8XDykgWJnHxMG4vGZnwF3Upt8qOUzgB1gxI4RelXYRvEYpk rnZkYzC09Obn0wsG6q4clYgu6Gp3ZZs0tAcfZ2RdalJ/EDE4TD8Oxg68XLdpSKVESjE1 N44ZN7jWLfPpHwDq7Ux4HxISj/Y++/fKtqZNF6+vsNi2cQHYXU7TyP6XVrlgkVJy1IG6 f8WDxtTncheEKCF0O5DIGgLUITyURTLKWlA5WzYthQBCi3ey/kC2ojlgwLys1oC0qS7z tNRgSxkw6k95uZCU7rhdFeGBqC4arUXaN0ybpNHt4nrQLaAx/xUCpfuZFSzx+tngDtDZ BDvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8/1Ko41seG/Gcm0WMFG2nw3d5RUz09+SdFfLxzqmI+Y=; b=1JfgJmc8CBjEdevmR5VD5zOF3ZPFFm8yfhU8/wwEYto9jYfpk3bRmlYMy8mJ1mF7kw olAYocPVmpm7HPMY4emDJxWH++dzr0fJs560HfDovfTUFpN23SJ8+eS4OGUcntXsvKXS 3FsDGyMkMf/trtkRxEa80vpHcS6m4nDnCh4l3EHDYlqw4OWpax5byu+CXbFuiWN31GVU w+YpA31CfeTryI+yDEG1VChmiMoQcuu5dkSoVB8LFnO+Vwm2dCZ2HwBJ1R7tex+3wS0A 7llZ8itXi2NleXSuLCh4eV8Rmlm4Z0PfKedD81lJRN8SCuTEwRWrdNtZcZq8qnjPyPVL mf7w== X-Gm-Message-State: AOAM5310sZ9xEQ2lv9CUWRfBPy1wUBNPp8qVdd5WkSzaesMqBlacHe4k qnx5oBgbRAhIf0ohyZlD7XxVEugRkB8wFA== X-Google-Smtp-Source: ABdhPJylRiAk8xI22jOcrIqwiVi33vbve6UeNUFi91annFZKh3Uzb8qARzjZWowIh8iJLzYTHFumMQ== X-Received: by 2002:a1c:2544:0:b0:381:18a:a46d with SMTP id l65-20020a1c2544000000b00381018aa46dmr294751wml.26.1645744663219; Thu, 24 Feb 2022 15:17:43 -0800 (PST) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id e33-20020a05600c4ba100b003810c690ba2sm3136456wmp.3.2022.02.24.15.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 15:17:42 -0800 (PST) Date: Thu, 24 Feb 2022 23:17:40 +0000 From: Phillip Potter To: Colin Ian King Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Michael Straube , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] staging: r8188eu: remove redundant variable reg_0x143 Message-ID: References: <20220224230658.151338-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224230658.151338-1-colin.i.king@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 11:06:58PM +0000, Colin Ian King wrote: > Variable reg_0x143 is being assigned a value, however is not being > read. The variable is redundant and can be removed. > > Signed-off-by: Colin Ian King > --- > drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > index cf58dfc3ff4d..53ebea311723 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c > @@ -189,7 +189,6 @@ static void efuse_read_phymap_from_txpktbuf( > { > u16 dbg_addr = 0; > u32 start = 0, passing_time = 0; > - u8 reg_0x143 = 0; > __le32 lo32 = 0, hi32 = 0; > u16 len = 0, count = 0; > int i = 0; > @@ -209,7 +208,7 @@ static void efuse_read_phymap_from_txpktbuf( > > rtw_write8(adapter, REG_TXPKTBUF_DBG, 0); > start = jiffies; > - while (!(reg_0x143 = rtw_read8(adapter, REG_TXPKTBUF_DBG)) && > + while (!rtw_read8(adapter, REG_TXPKTBUF_DBG) && > (passing_time = rtw_get_passing_time_ms(start)) < 1000) > rtw_usleep_os(100); > > -- > 2.34.1 > Looks good to me, thanks Colin. Reviewed-by: Phillip Potter Regards, Phil