public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Samuel Sjöberg" <info@samuelsjoberg.se>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: rts5208: fix Lines should not end with a '('.
Date: Fri, 25 Feb 2022 10:01:05 +0100	[thread overview]
Message-ID: <Yhia0QoJTT9IB2UW@kroah.com> (raw)
In-Reply-To: <20220221214344.5895-1-info@samuelsjoberg.se>

On Mon, Feb 21, 2022 at 10:43:44PM +0100, Samuel Sjöberg wrote:
> Fix the following error reported by checkpatch.pl:
> 
> CHECK: Lines should not end with a '('
> +                                       retval = ms_transfer_tpc(
> 
> Signed-off-by: Samuel Sjöberg <info@samuelsjoberg.se>
> ---
> Changes in v2:
>   - Fixed subject line and commit message.
> 
>  drivers/staging/rts5208/ms.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> index 2a6fab5c117a..14449f8afad5 100644
> --- a/drivers/staging/rts5208/ms.c
> +++ b/drivers/staging/rts5208/ms.c
> @@ -1749,11 +1749,10 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk,
>  
>  				for (rty_cnt = 0; rty_cnt < MS_MAX_RETRY_COUNT;
>  				     rty_cnt++) {
> -					retval = ms_transfer_tpc(
> -						chip,
> -						MS_TM_NORMAL_WRITE,
> -						WRITE_PAGE_DATA,
> -						0, NO_WAIT_INT);
> +					retval = ms_transfer_tpc(chip,
> +								 MS_TM_NORMAL_WRITE,
> +								 WRITE_PAGE_DATA,
> +								 0, NO_WAIT_INT);
>  					if (retval == STATUS_SUCCESS)
>  						break;
>  				}
> -- 
> 2.35.1
> 

This change never ended up on the mailing list for some reason :(

Please fix up and resend.

thanks,

greg k-h

           reply	other threads:[~2022-02-25  9:01 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220221214344.5895-1-info@samuelsjoberg.se>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yhia0QoJTT9IB2UW@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=info@samuelsjoberg.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox