From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices
Date: Fri, 25 Feb 2022 10:35:02 +0100 [thread overview]
Message-ID: <Yhiixm/iRlnF18B7@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2202121706060.34636@angie.orcam.me.uk>
On Sat, Feb 12, 2022 at 05:30:59PM +0000, Maciej W. Rozycki wrote:
> Provide information in the kernel log as to what configuration option to
> enable for PCI UART devices that have been blacklisted in the generic
> PCI 8250 UART driver and which have a dedicated driver available to
> handle that has been disabled. The rationale is there is no easy way
> for the user to map a specific PCI vendor:device pair to an individual
> dedicated driver while the generic driver has this information readily
> available and it will likely be confusing that the generic driver does
> not register such a port.
>
> A message is then printed like:
>
> serial 0000:04:00.3: ignoring port, enable SERIAL_8250_PERICOM to handle
>
> when an affected device is encountered and the generic driver rejects it.
>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
I've applied patch 1 of this series, but this is really an odd one.
We don't do this for any other driver subsystem, so why is it really
needed? What is so special about this driver that distros can't
just enable all of the drivers and all is good? What is keeping those
drivers fromb eing enabled?
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-25 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 17:30 [PATCH v2 0/2] serial: 8250: Correct basic issues with the PCI blacklist Maciej W. Rozycki
2022-02-12 17:30 ` [PATCH v2 1/2] serial: 8250: Correct Kconfig help text for blacklisted PCI devices Maciej W. Rozycki
2022-02-12 17:30 ` [PATCH v2 2/2] serial: 8250: Report which option to enable " Maciej W. Rozycki
2022-02-25 9:35 ` Greg Kroah-Hartman [this message]
2022-02-26 10:32 ` Maciej W. Rozycki
2022-02-27 23:06 ` Maciej W. Rozycki
2022-03-31 7:12 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhiixm/iRlnF18B7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox