Re: [PATCH 0/4] KVM: x86: hyper-v: XMM fast hypercalls fixes

Paolo Bonzini
2022-02-25T13:17:47Z

On 2/25/22 14:13, Vitaly Kuznetsov wrote:
> Let's say we have 1 half of XMM0 consumed. Now:
>
> i = 0;
> j = 1;
> if (1)
> sparse_banks[0] = sse128_lo(hc->xmm[0]);
>
> This doesn't look right as we need to get the upper half of XMM0.
>
> I guess it should be reversed,
>
> if (j % 2)
> sparse_banks[i] = sse128_hi(hc->xmm[j / 2]);
> else
> sparse_banks[i] = sse128_lo(hc->xmm[j / 2]);

Yeah, of course.

Thanks!

Paolo