Re: [PATCH 0/4] KVM: x86: hyper-v: XMM fast hypercalls fixes

Siddharth Chandrasekaran
2022-02-28T10:54:33Z

On Fri, Feb 25, 2022 at 02:17:04PM +0100, Paolo Bonzini wrote:
> On 2/25/22 14:13, Vitaly Kuznetsov wrote:
> > Let's say we have 1 half of XMM0 consumed. Now:
> >
> > i = 0;
> > j = 1;
> > if (1)
> > sparse_banks[0] = sse128_lo(hc->xmm[0]);
> >
> > This doesn't look right as we need to get the upper half of XMM0.
> >
> > I guess it should be reversed,
> >
> > if (j % 2)
> > sparse_banks[i] = sse128_hi(hc->xmm[j / 2]);
> > else
> > sparse_banks[i] = sse128_lo(hc->xmm[j / 2]);

Maybe I am missing parts of this series.. I dont see this change in any
of the 4 patches Vitaly sent. Yes, they look swapped to me too.

~ Sid.

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879