From: Rob Herring <robh@kernel.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Frank Wunderlich <linux@fw-web.de>,
devicetree@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
soc@kernel.org, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name
Date: Mon, 14 Mar 2022 15:50:24 -0600 [thread overview]
Message-ID: <Yi+4oN5xuS2pq0ru@robh.at.kernel.org> (raw)
In-Reply-To: <trinity-0f1389c2-6d2b-4499-a2fc-3cb93f4d09cb-1647272336831@3c-app-gmx-bap56>
On Mon, Mar 14, 2022 at 04:38:56PM +0100, Frank Wunderlich wrote:
> Hi,
>
> thanks for for checking the spear-patch.
>
> > Gesendet: Montag, 14. März 2022 um 04:49 Uhr
> > Von: "Viresh Kumar" <viresh.kumar@linaro.org>
> >
> > On 11-03-22, 22:03, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@public-files.de>
> > >
> > > After converting the binding to yaml the node name does
> > > not match the standard pattern, change it.
> > >
> > > arch/arm/boot/dts/spear1340-evb.dt.yaml: ahci@b1000000:
> > > $nodename:0: 'ahci@b1000000' does not match '^sata(@.*)?$'
> > > From schema: Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > >
> > > Fixes: 07658d9a659b ("SPEAr13xx: Add dts and dtsi files")
> >
> > I don't think this is correct. The above patch is correct. The first
> > patch in this series changes the names and that's where things break.
>
> it's right that my binding will break it, but the nodes are not named the right way.
> And i used the commit that introduces the wrong node-names.
> Maybe fixes-tag is wrong in this case.
I'm pretty sure Viresh just meant the Fixes tag is not right.
Rob
next prev parent reply other threads:[~2022-03-14 21:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 21:03 [PATCH v6 0/6] Add sata nodes to rk356x Frank Wunderlich
2022-03-11 21:03 ` [PATCH v6 1/6] dt-bindings: ata: ahci-platform: Convert DT bindings to yaml Frank Wunderlich
2022-03-12 3:45 ` Rob Herring
2022-03-11 21:03 ` [PATCH v6 2/6] arm64: dts: marvell: Fix anyOf conditional failed Frank Wunderlich
2022-03-11 21:03 ` [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name Frank Wunderlich
2022-03-14 3:49 ` Viresh Kumar
2022-03-14 15:38 ` Aw: " Frank Wunderlich
2022-03-14 21:50 ` Rob Herring [this message]
2022-03-15 2:49 ` Viresh Kumar
2022-03-11 21:03 ` [PATCH v6 4/6] dt-bindings: ata: ahci-platform: Add power-domains property Frank Wunderlich
2022-03-12 3:45 ` Rob Herring
2022-03-11 21:03 ` [PATCH v6 5/6] dt-bindings: ata: ahci-platform: Add rk3568-dwc-ahci compatible Frank Wunderlich
2022-03-12 3:45 ` Rob Herring
2022-03-11 21:03 ` [PATCH v6 6/6] arm64: dts: rockchip: Add sata nodes to rk356x Frank Wunderlich
2022-03-12 8:00 ` [PATCH v6 0/6] " Damien Le Moal
2022-03-12 8:26 ` Frank Wunderlich
2022-03-14 15:41 ` Rob Herring
2022-03-15 11:00 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi+4oN5xuS2pq0ru@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox