From: Andrew Lunn <andrew@lunn.ch>
To: Kurt Cancemi <kurt@x64architecture.com>
Cc: netdev@vger.kernel.org, kabel@kernel.org,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Charles-Antoine Couret <charles-antoine.couret@nexvision.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: phy: marvell: Fix invalid comparison in the resume and suspend functions
Date: Sat, 12 Mar 2022 21:25:08 +0100 [thread overview]
Message-ID: <Yi0BpO5er+5w7UDY@lunn.ch> (raw)
In-Reply-To: <20220312201512.326047-1-kurt@x64architecture.com>
On Sat, Mar 12, 2022 at 03:15:13PM -0500, Kurt Cancemi wrote:
> This bug resulted in only the current mode being resumed and suspended when
> the PHY supported both fiber and copper modes and when the PHY only supported
> copper mode the fiber mode would incorrectly be attempted to be resumed and
> suspended.
>
> Fixes: 3758be3dc162 ("Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.")
> Signed-off-by: Kurt Cancemi <kurt@x64architecture.com>
Hi Kurt
Best practice is to add any Reviewed-by or Tested-by to the patch
whenever you repost it, except when you make major changes. Otherwise
they can get lost.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-03-12 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220312002016.60416-1-kurt@x64architecture.com>
2022-03-12 20:15 ` [PATCH net v3] net: phy: marvell: Fix invalid comparison in the resume and suspend functions Kurt Cancemi
2022-03-12 20:25 ` Andrew Lunn [this message]
2022-03-14 22:07 ` Jakub Kicinski
2022-03-14 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi0BpO5er+5w7UDY@lunn.ch \
--to=andrew@lunn.ch \
--cc=charles-antoine.couret@nexvision.fr \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=kurt@x64architecture.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox