From: Al Viro <viro@zeniv.linux.org.uk>
To: Max Kellermann <max.kellermann@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] pipe_fs_i.h: add pipe_buf_init()
Date: Sun, 13 Mar 2022 02:37:43 +0000 [thread overview]
Message-ID: <Yi1Y99MX7yxD2k6m@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20220225185431.2617232-4-max.kellermann@gmail.com>
On Fri, Feb 25, 2022 at 07:54:31PM +0100, Max Kellermann wrote:
> /* Insert it into the buffer array */
> buf = &pipe->bufs[head & mask];
> - buf->page = page;
> - buf->ops = &anon_pipe_buf_ops;
> - buf->offset = 0;
> - buf->len = 0;
> - if (is_packetized(filp))
> - buf->flags = PIPE_BUF_FLAG_PACKET;
> - else
> - buf->flags = PIPE_BUF_FLAG_CAN_MERGE;
> + pipe_buf_init(buf, page, 0, 0,
> + &anon_pipe_buf_ops,
> + is_packetized(filp) ? PIPE_BUF_FLAG_PACKET : PIPE_BUF_FLAG_CAN_MERGE);
*cringe*
FWIW, packetized case is very rare, so how about turning that into
pipe_buf_init(buf, page, 0, 0,
&anon_pipe_buf_ops,
PIPE_BUF_FLAG_CAN_MERGE);
if (unlikely(is_packetized(filp)))
buf->flags = PIPE_BUF_FLAG_PACKET;
Your pipe_buf_init() is inlined, so it shouldn't be worse from the optimizer
POV - it should be able to start with calculating that value and then storing
that, etc.
next prev parent reply other threads:[~2022-03-13 2:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 18:54 [PATCH 1/4] include/pipe_fs_i.h: add missing #includes Max Kellermann
2022-02-25 18:54 ` [PATCH 2/4] fs/pipe: remove duplicate "offset" initializer Max Kellermann
2022-02-25 18:54 ` [PATCH 3/4] fs/pipe: remove unnecessary "buf" initializer Max Kellermann
2022-02-25 18:54 ` [PATCH 4/4] pipe_fs_i.h: add pipe_buf_init() Max Kellermann
2022-03-13 2:37 ` Al Viro [this message]
2022-03-13 2:48 ` Matthew Wilcox
2022-03-13 4:34 ` Al Viro
2022-03-13 6:47 ` Max Kellermann
2022-03-13 1:49 ` [PATCH 1/4] include/pipe_fs_i.h: add missing #includes Al Viro
2022-03-13 6:45 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi1Y99MX7yxD2k6m@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox