public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Xin Ji <xji@analogixsemi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	bliang@analogixsemi.com, qwen@analogixsemi.com,
	jli@analogixsemi.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
Date: Thu, 3 Mar 2022 15:13:33 +0200	[thread overview]
Message-ID: <YiC+/ccRvR/+mAkT@kuha.fi.intel.com> (raw)
In-Reply-To: <20220303024757.GA4159259@anxtwsw-Precision-3640-Tower>

On Thu, Mar 03, 2022 at 10:47:57AM +0800, Xin Ji wrote:
> On Wed, Mar 02, 2022 at 02:03:18PM +0200, Heikki Krogerus wrote:
> > Hi,
> > 
> > This does not apply on top of Greg's latest usb-next branch. You need
> > to rebase this. There are also a few more nitpicks below.
> 
> Hi, I didn't found tcpci.h in include/linux/usb/

I'm asking you to create the file.

So create a separate patch where you move the register definitions and
command definitions from drivers/usb/typec/tcpm/tcpci.h to
include/linux/usb/tcpci.h

thanks,

-- 
heikki

  reply	other threads:[~2022-03-03 13:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 10:23 [PATCH v6 1/2] dt-bindings: usb: Add analogix anx7411 PD binding Xin Ji
2022-02-23 10:23 ` [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support Xin Ji
2022-03-02 12:03   ` Heikki Krogerus
2022-03-03  2:47     ` Xin Ji
2022-03-03 13:13       ` Heikki Krogerus [this message]
2022-03-04  2:29         ` Xin Ji
2022-03-04 12:28           ` Heikki Krogerus
2022-03-07  5:58             ` Xin Ji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiC+/ccRvR/+mAkT@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=bliang@analogixsemi.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jli@analogixsemi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=qwen@analogixsemi.com \
    --cc=xji@analogixsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox