public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: mathias.nyman@intel.com, kernel@puri.sm,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: make XHCI_STOP_EP_CMD_TIMEOUT a module parameter
Date: Fri, 4 Mar 2022 15:17:08 +0100	[thread overview]
Message-ID: <YiIfZFPl9ZqPBKvj@kroah.com> (raw)
In-Reply-To: <20220304113057.1477958-1-martin.kepplinger@puri.sm>

On Fri, Mar 04, 2022 at 12:30:57PM +0100, Martin Kepplinger wrote:
> On the Librem 5 imx8mq system we've seen the stop endpoint command
> time out regularly which results in the hub dying.
> 
> While on the one hand we see "Port resume timed out, port 1-1: 0xfe3"
> before this and on the other hand driver-comments suggest that the driver
> might be able to recover instead of dying here, Sarah seemed to have a
> workaround for this particulator problem in mind already:
> 
> Make it a module parameter. So while it might not be the root cause for
> the problem, do this to give users a workaround.

This is not the 1990's, sorry, please do not add new module parameters.
They modify code, when you want to modify an individual device.

thanks,

greg k-h

  parent reply	other threads:[~2022-03-04 14:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 11:30 [PATCH] usb: xhci: make XHCI_STOP_EP_CMD_TIMEOUT a module parameter Martin Kepplinger
2022-03-04 11:52 ` Martin Kepplinger
2022-03-04 14:17 ` Greg KH [this message]
2022-03-07  8:49   ` Mathias Nyman
2022-03-08 16:17     ` Martin Kepplinger
2022-03-09  7:56       ` Martin Kepplinger
2022-03-09  9:29         ` Mathias Nyman
2022-03-15  8:43           ` Martin Kepplinger
2022-03-21 13:47             ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiIfZFPl9ZqPBKvj@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kernel@puri.sm \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox