From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD552C433F5 for ; Fri, 4 Mar 2022 14:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239613AbiCDOSk (ORCPT ); Fri, 4 Mar 2022 09:18:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbiCDOSi (ORCPT ); Fri, 4 Mar 2022 09:18:38 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1842559B; Fri, 4 Mar 2022 06:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646403470; x=1677939470; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=or3pXL7frdL+sQOxlxnzqbp2iB/FyXVFN2iAqqfq00c=; b=gFMQ9jfeg38vNguS5itQreotU4r2bH/Brn7m+7HSPGJ63/+LFihsNQp+ 2azxkFZPQ28jKmGDY8s5zjVYH3ufj3L8/pPEoD4X0+ND1Jhm+qMvCOuKS rtRzGHOsotROQfa4BmiGsrL2cbWV/ps0p5LfJUGQlL3l9ZXRSKvN1GDt/ ZWcTyPCwWF6kqadDRhou9FTLtyl3yS8Nj7eN5OwihB/8Cq4XQV3LFIsAv VJutUV+urkdsRLvzg/CCxyBaPrF+wHmNvx+tg47awQCqGOwCK5OmWl4iU H/XtkoJhlGFopRg1P8aT3gJzN+orsJiUXEeQ7QxS9ulvthT7ymDj/wTOd A==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="253711653" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="253711653" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 06:17:50 -0800 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="710345703" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 06:17:48 -0800 Received: by lahna (sSMTP sendmail emulation); Fri, 04 Mar 2022 16:17:45 +0200 Date: Fri, 4 Mar 2022 16:17:45 +0200 From: Mika Westerberg To: Mario Limonciello Cc: "open list:THUNDERBOLT DRIVER" , linux-kernel@vger.kernel.org, Sanju.Mehta@amd.com Subject: Re: [PATCH v2 1/5] thunderbolt: Retry DROM reads for more failure scenarios Message-ID: References: <20220303131328.4150454-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303131328.4150454-1-mario.limonciello@amd.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mario, On Thu, Mar 03, 2022 at 07:13:24AM -0600, Mario Limonciello wrote: > Currently DROM reads are only retried in the case that parsing failed. > However if the size or CRC fails, then there should also be a retry. > > This helps with reading the DROM on TBT3 devices connected to AMD > Yellow Carp which will sometimes fail on the first attempt. > > Signed-off-by: Mario Limonciello This and the rest of the patches applied to thunderbolt.git/next, thanks!