From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH v4 3/3] iio: temperature: ltc2983: Make use of device properties
Date: Fri, 4 Mar 2022 20:28:22 +0200 [thread overview]
Message-ID: <YiJaRoIVSU8fIly3@smile.fi.intel.com> (raw)
In-Reply-To: <20220304180257.80298-3-andriy.shevchenko@linux.intel.com>
On Fri, Mar 04, 2022 at 08:02:57PM +0200, Andy Shevchenko wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> The conversion slightly changes the logic behind property reading for
> the configuration values. Original code allocates just as much memory
> as needed. Then for each separate 32- or 64-bit value it reads it from
> the property and converts to a raw one which will be fed to the sensor.
> In the new code we allocate the amount of memory needed to retrieve all
> values at once from the property and then convert them as required.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Tested-by: Nuno Sá <nuno.sa@analog.com>
> ---
> v4: added checks for error pointer (Nuno), added Tb tag (Nuno)
> v3: no changes
Forgot to add, that this patch should work without fwnode fix.
To test fwnode fix, the part of the NULLifying ref should be
(temporary) dropped.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-04 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 18:02 [PATCH v4 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Andy Shevchenko
2022-03-04 18:02 ` [PATCH v4 2/3] iio: temperature: ltc2983: Use single error path to put OF node Andy Shevchenko
2022-03-04 18:02 ` [PATCH v4 3/3] iio: temperature: ltc2983: Make use of device properties Andy Shevchenko
2022-03-04 18:28 ` Andy Shevchenko [this message]
2022-03-05 12:39 ` Nuno Sá
2022-03-07 16:09 ` Sa, Nuno
2022-03-07 16:19 ` Sa, Nuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiJaRoIVSU8fIly3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox