Re: [PATCH 07/16] dept: Apply Dept to wait_for_completion()/complete()

kernel test robot
2022-02-17T19:47:27Z

Hi Byungchul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on linux/master linus/master v5.17-rc4]
[cannot apply to tip/locking/core hnaz-mm/master next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Byungchul-Park/DEPT-Dependency-Tracker/20220217-190040
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 3624ba7b5e2acc02b01301ea5fd3534971eb9896
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220218/202202180000.zICbPUhq-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8ef6cb09cb67a0c5cd7ba4f25f4825d0a5b269b0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Byungchul-Park/DEPT-Dependency-Tracker/20220217-190040
git checkout 8ef6cb09cb67a0c5cd7ba4f25f4825d0a5b269b0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/scsi/qla2xxx/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/scsi/qla2xxx/qla_dfs.c: In function 'qla2x00_dfs_tgt_port_database_show':
>> drivers/scsi/qla2xxx/qla_dfs.c:227:1: warning: the frame size of 1028 bytes is larger than 1024 bytes [-Wframe-larger-than=]
227 | }
| ^

vim +227 drivers/scsi/qla2xxx/qla_dfs.c

36c7845282eef01 Quinn Tran 2016-02-04 174
c423437e3ff41b8 Himanshu Madhani 2017-03-15 175 static int
c423437e3ff41b8 Himanshu Madhani 2017-03-15 176 qla2x00_dfs_tgt_port_database_show(struct seq_file *s, void *unused)
c423437e3ff41b8 Himanshu Madhani 2017-03-15 177 {
c423437e3ff41b8 Himanshu Madhani 2017-03-15 178 scsi_qla_host_t *vha = s->private;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 179 struct qla_hw_data *ha = vha->hw;
4e5a05d1ecd92ce Arun Easi 2020-09-03 180 struct gid_list_info *gid_list;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 181 dma_addr_t gid_list_dma;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 182 fc_port_t fc_port;
4e5a05d1ecd92ce Arun Easi 2020-09-03 183 char *id_iter;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 184 int rc, i;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 185 uint16_t entries, loop_id;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 186
c423437e3ff41b8 Himanshu Madhani 2017-03-15 187 seq_printf(s, "%s\n", vha->host_str);
c423437e3ff41b8 Himanshu Madhani 2017-03-15 188 gid_list = dma_alloc_coherent(&ha->pdev->dev,
c423437e3ff41b8 Himanshu Madhani 2017-03-15 189 qla2x00_gid_list_size(ha),
c423437e3ff41b8 Himanshu Madhani 2017-03-15 190 &gid_list_dma, GFP_KERNEL);
c423437e3ff41b8 Himanshu Madhani 2017-03-15 191 if (!gid_list) {
83548fe2fcbb78a Quinn Tran 2017-06-02 192 ql_dbg(ql_dbg_user, vha, 0x7018,
c423437e3ff41b8 Himanshu Madhani 2017-03-15 193 "DMA allocation failed for %u\n",
c423437e3ff41b8 Himanshu Madhani 2017-03-15 194 qla2x00_gid_list_size(ha));
c423437e3ff41b8 Himanshu Madhani 2017-03-15 195 return 0;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 196 }
c423437e3ff41b8 Himanshu Madhani 2017-03-15 197
c423437e3ff41b8 Himanshu Madhani 2017-03-15 198 rc = qla24xx_gidlist_wait(vha, gid_list, gid_list_dma,
c423437e3ff41b8 Himanshu Madhani 2017-03-15 199 &entries);
c423437e3ff41b8 Himanshu Madhani 2017-03-15 200 if (rc != QLA_SUCCESS)
c423437e3ff41b8 Himanshu Madhani 2017-03-15 201 goto out_free_id_list;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 202
4e5a05d1ecd92ce Arun Easi 2020-09-03 203 id_iter = (char *)gid_list;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 204
c423437e3ff41b8 Himanshu Madhani 2017-03-15 205 seq_puts(s, "Port Name Port ID Loop ID\n");
c423437e3ff41b8 Himanshu Madhani 2017-03-15 206
c423437e3ff41b8 Himanshu Madhani 2017-03-15 207 for (i = 0; i < entries; i++) {
4e5a05d1ecd92ce Arun Easi 2020-09-03 208 struct gid_list_info *gid =
4e5a05d1ecd92ce Arun Easi 2020-09-03 209 (struct gid_list_info *)id_iter;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 210 loop_id = le16_to_cpu(gid->loop_id);
c423437e3ff41b8 Himanshu Madhani 2017-03-15 211 memset(&fc_port, 0, sizeof(fc_port_t));
c423437e3ff41b8 Himanshu Madhani 2017-03-15 212
c423437e3ff41b8 Himanshu Madhani 2017-03-15 213 fc_port.loop_id = loop_id;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 214
c423437e3ff41b8 Himanshu Madhani 2017-03-15 215 rc = qla24xx_gpdb_wait(vha, &fc_port, 0);
c423437e3ff41b8 Himanshu Madhani 2017-03-15 216 seq_printf(s, "%8phC %02x%02x%02x %d\n",
c423437e3ff41b8 Himanshu Madhani 2017-03-15 217 fc_port.port_name, fc_port.d_id.b.domain,
c423437e3ff41b8 Himanshu Madhani 2017-03-15 218 fc_port.d_id.b.area, fc_port.d_id.b.al_pa,
c423437e3ff41b8 Himanshu Madhani 2017-03-15 219 fc_port.loop_id);
4e5a05d1ecd92ce Arun Easi 2020-09-03 220 id_iter += ha->gid_list_info_size;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 221 }
c423437e3ff41b8 Himanshu Madhani 2017-03-15 222 out_free_id_list:
c423437e3ff41b8 Himanshu Madhani 2017-03-15 223 dma_free_coherent(&ha->pdev->dev, qla2x00_gid_list_size(ha),
c423437e3ff41b8 Himanshu Madhani 2017-03-15 224 gid_list, gid_list_dma);
c423437e3ff41b8 Himanshu Madhani 2017-03-15 225
c423437e3ff41b8 Himanshu Madhani 2017-03-15 226 return 0;
c423437e3ff41b8 Himanshu Madhani 2017-03-15 @227 }
c423437e3ff41b8 Himanshu Madhani 2017-03-15 228

---
0-DAY CI Kernel Test Service, Intel Corporation