From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4A9C433FE for ; Tue, 8 Mar 2022 19:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350025AbiCHTt2 (ORCPT ); Tue, 8 Mar 2022 14:49:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240345AbiCHTtZ (ORCPT ); Tue, 8 Mar 2022 14:49:25 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E76AA39812 for ; Tue, 8 Mar 2022 11:48:28 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id k5-20020a17090a3cc500b001befa0d3102so2466842pjd.1 for ; Tue, 08 Mar 2022 11:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4fyfnxj92k5W9rcKN1dJwICOBJKughLQrnvCk7UQagQ=; b=Cxpew77bEL6PrGKAI6JSibIWnNHYAAuwav23jRL4Du8wLegKGlUwDfTSeV0ZT0wwg3 KV4wz2azpR9tupf/1B4UOwNb+hsvbMhWOjpWUIktiXhypAAGAFKiEFPomvy48kgV4sfs /PaCk9ttAd1buxNYKAguc5onYFZuklHIoY4Mxe3SIcZN/BaHiSSC7JeemtshtgQJxpVE PcaUc1Wyms6fDjFhje3QNL0O9D62SgaTraCk/grIkkOFmA/h/NbRjqQ4Uq5j5JpQHHls D0JVfMbNhBSRRTwDs9b/5qYZSzcta1y3IlRU4rPYQQimFgDbUhassg2abiRcsE2MQbc8 TE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4fyfnxj92k5W9rcKN1dJwICOBJKughLQrnvCk7UQagQ=; b=lsBLEX4ibbXtuc6pdEqsoas+xJ6EbPFYND8mewsmRDRszeHfO9AYNNMtSX6K/AgwY3 hK5+wdW5Wz4k/riRP0ds8L+fibhKwOVXjpR/w/CpuacvziuGEzXyB999WQiNlOH4ulpr jmluPZ9Q/UPR9SBlonjtFQgf8FFBJbSVUnDXTqAFQ+2ouo/7VEoRgDh/4/a/tNZhOtP0 7JuuJkci+uoZ+SHL8WsmyvkYlXW6vPMpFh8haIROvRik+sgvUINp6+hbXDAIx5TUCKhV HHXvAd3esi/yhvjMdWJ+b02lCphnHZelqJ6p2VZXgEi58WHXtRyntK6gGao/6sBLVnKu K/VA== X-Gm-Message-State: AOAM530OFwwoucgdjX1Hn10dbHMpRYkoRGN06siVy+jndtGGAjBOlXFK 56lA2YEUag6Vw027cIOrxwjkser9zqAvNw== X-Google-Smtp-Source: ABdhPJwUIm6VOlVKu5rtCXgksk7sRQfJvaYEQ+1/a90qbq+A0jEgprS5omGyN+F7ZQmkI2kSJLrORg== X-Received: by 2002:a17:90a:a78d:b0:1bc:d11c:ad40 with SMTP id f13-20020a17090aa78d00b001bcd11cad40mr6381715pjq.246.1646768908344; Tue, 08 Mar 2022 11:48:28 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id l11-20020a17090a660b00b001bf576cd2fasm3677893pjj.37.2022.03.08.11.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 11:48:27 -0800 (PST) Date: Tue, 8 Mar 2022 19:48:24 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dmatlack@google.com Subject: Re: [PATCH v2 21/25] KVM: x86/mmu: replace shadow_root_level with root_role.level Message-ID: References: <20220221162243.683208-1-pbonzini@redhat.com> <20220221162243.683208-22-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221162243.683208-22-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022, Paolo Bonzini wrote: > root_role.level is always the same value as shadow_level: > > - it's kvm_mmu_get_tdp_level(vcpu) when going through init_kvm_tdp_mmu > > - it's the level argument when going through kvm_init_shadow_ept_mmu > > - it's assigned directly from new_role.base.level when going > through shadow_mmu_init_context > > Remove the duplication and get the level directly from the role. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/include/asm/kvm_host.h | 1 - > arch/x86/kvm/mmu.h | 2 +- > arch/x86/kvm/mmu/mmu.c | 33 ++++++++++++++------------------- > arch/x86/kvm/mmu/tdp_mmu.c | 2 +- > arch/x86/kvm/svm/svm.c | 2 +- > arch/x86/kvm/vmx/vmx.c | 2 +- > 6 files changed, 18 insertions(+), 24 deletions(-) Yay! That's a lot less churn than I expected. Reviewed-by: Sean Christopherson