Re: [PATCH v6 6/9] KVM: x86: lapic: don't allow to change APIC ID unconditionally

David Woodhouse
2022-02-25T15:42:55Z

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

On Fri, 2022-02-25 at 17:11 +0200, Maxim Levitsky wrote:
> On Fri, 2022-02-25 at 14:56 +0000, David Woodhouse wrote:
> > On Fri, 2022-02-25 at 16:46 +0200, Maxim Levitsky wrote:
> > > Assuming that this is approved and accepted upstream,
> > > that is even better that my proposal of doing this
> > > when APICv is enabled.
> > >
> > > Since now apic id is always read only, now we should not
> > > forget to clean up some parts of kvm like kvm_recalculate_apic_map,
> > > which are not needed anymore
> >
> > Can we also now optimise kvm_get_vcpu_by_id() so it doesn't have to do
> > a linear search over all the vCPUs when there isn't a 1:1
> > correspondence with the vCPU index?
>
> I don't think so since vcpu id can still be set by userspace to anything,
> and this is even used to encode topology in it.

Yes, but it can only be set at vCPU creation time and it has to be
unique.

> However a hash table can still be used there to speed it up regardless of
> read-only apic id IMHO.
>
> Or, even better than a hash table, I see that KVM already
> limits vcpu_id to KVM_MAX_VCPUS * 4 with a comment that only two extra
> bits of topology are used:

We already have the kvm_apic_map which provides a fast lookup. The key
point here is that the APIC ID can't *change* from vcpu->vcpu_id any
more, so we can actually use the kvm_apic_map for kvm_get_vcpu_by_id()
now, can't we?

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]