Re: [PATCH v6 6/9] KVM: x86: lapic: don't allow to change APIC ID unconditionally

David Woodhouse
2022-02-25T14:56:39Z

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

On Fri, 2022-02-25 at 16:46 +0200, Maxim Levitsky wrote:
> On Fri, 2022-02-25 at 16:22 +0800, Zeng Guang wrote:
> > From: Maxim Levitsky <
> > mlevitsk@redhat.com
> > >
> >
> > No normal guest has any reason to change physical APIC IDs, and
> > allowing this introduces bugs into APIC acceleration code.
> >
> > And Intel recent hardware just ignores writes to APIC_ID in
> > xAPIC mode. More background can be found at:
> > https://lore.kernel.org/lkml/Yfw5ddGNOnDqxMLs@google.com/
> >
> >
> > Looks there is no much value to support writable xAPIC ID in
> > guest except supporting some old and crazy use cases which
> > probably would fail on real hardware. So, make xAPIC ID
> > read-only for KVM guests.
> >
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > Signed-off-by: Zeng Guang <guang.zeng@intel.com>
>
> Assuming that this is approved and accepted upstream,
> that is even better that my proposal of doing this
> when APICv is enabled.
>
> Since now apic id is always read only, now we should not
> forget to clean up some parts of kvm like kvm_recalculate_apic_map,
> which are not needed anymore

Can we also now optimise kvm_get_vcpu_by_id() so it doesn't have to do
a linear search over all the vCPUs when there isn't a 1:1
correspondence with the vCPU index?

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]