Re: [PATCH bpf-next v2 10/28] selftests/bpf: add report descriptor fixup tests

Greg KH
2022-03-04T18:35:12Z

On Fri, Mar 04, 2022 at 06:28:34PM +0100, Benjamin Tissoires wrote:
> Simple report descriptor override in HID: replace part of the report
> descriptor from a static definition in the bpf kernel program.
>
> Note that this test should be run last because we disconnect/reconnect
> the device, meaning that it changes the overall uhid device.

You might want to add that in a comment right before:

> @@ -329,6 +395,9 @@ void serial_test_hid_bpf(void)
> err = test_hid_raw_event(hid_skel, uhid_fd, sysfs_fd);
> ASSERT_OK(err, "hid");
>
> + err = test_rdesc_fixup(hid_skel, uhid_fd, sysfs_fd);
> + ASSERT_OK(err, "hid_rdesc_fixup");

There, so that you don't add another test after this later on in 5
years.

Anyway, just a nit:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>