Re: [PATCH v3 0/4] Add tracer tool for AMD P-State driver

Huang Rui
2022-03-09T13:32:20Z

On Wed, Mar 09, 2022 at 09:23:47AM +0800, Su, Jinzhou (Joe) wrote:
> Hello,
>
> intel_pstate_tracer is a useful tool to analyze the performance of
> intel_pstate driver. We upstream out AMD P-state driver into Linux
> kernel recently and like to use similar tool to tune the performance
> of the driver.
>
> I modified intel_pstate_tracer.py then it could import as a module to
> analyze AMD P-State trace event. Other trace event also can benifit from
> this change once they need this tool.
>
> intel_pstate_tracer could be used as the same way as before and the
> original functionality isn't broken.
>
> Changes from V2->V3
>
> -fix typo in amd-pstate RST
>
> Changes from V1->V2
>
> -Add tracer documentation in amd-pstate RST
>
> -fix typo in amd_pstate_trace.py
>
> -add "Co-developed-by" in patch 1/4
>
> Thanks,
> Joe
>
> Jinzhou Su (4):
> cpufreq: amd-pstate: Add more tracepoint for AMD P-State module
> tools/power/x86/intel_pstate_tracer: make tracer as a module
> tools/power/x86/amd_pstate_tracer: Add tracer tool for AMD P-state
> Documentation: amd-pstate: add tracer tool introduction

Series are Reviewed-by: Huang Rui <ray.huang@amd.com>

>
> Documentation/admin-guide/pm/amd-pstate.rst | 26 ++
> MAINTAINERS | 1 +
> drivers/cpufreq/amd-pstate-trace.h | 22 +-
> drivers/cpufreq/amd-pstate.c | 59 ++-
> .../x86/amd_pstate_tracer/amd_pstate_trace.py | 354 ++++++++++++++++++
> .../intel_pstate_tracer.py | 260 +++++++------
> 6 files changed, 588 insertions(+), 134 deletions(-)
> create mode 100755 tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py
>
> --
> 2.27.0
>