From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A89AC433EF for ; Wed, 9 Mar 2022 19:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233144AbiCITTe (ORCPT ); Wed, 9 Mar 2022 14:19:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237602AbiCITT3 (ORCPT ); Wed, 9 Mar 2022 14:19:29 -0500 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E3811477D for ; Wed, 9 Mar 2022 11:18:20 -0800 (PST) Received: by mail-qt1-x830.google.com with SMTP id s15so2737725qtk.10 for ; Wed, 09 Mar 2022 11:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=V59HgvRc61glNOVchpXeR9lrKfDnI5JVZxCRrOe4PRw=; b=iI4AVJfDe2rTLVR5kFUQ47GJYK0B64dsIEiT0iiLSmBiX/DirSdJUpyJg1gkefekcd 7rZpVe2BLc878GhnKz7ojbP41jmTM/KchQ5Rr+DmAMxO1Tr5AJXQpbvV7Wu/9KbHXGSW 1cEi85cR1+tl0b3zerdE35IYi3cjOJhODO4pcmugXZhgtEHUS5Q/mppaZKrA0xq8choB sqKnLqxJ5LAVyge5tVouHdQ+SY3H6pMT6vO1LnjN2WAMYUhUJzpTH6AvCDFhw39/i4Ly Oo/ERGpImlyfJsA0F269mgwQIeJEqoQqqtFgevrd9EnVCJrtdIzX5C0O/ca/mjG1lql3 SPxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V59HgvRc61glNOVchpXeR9lrKfDnI5JVZxCRrOe4PRw=; b=Q4t7kdYkBQBc7R6qryRgHBguEi7YyG1KA0iAdOxS7T+qcks498qBXztfB7xrF45TxX jeTD5mqtgvGeqEbMZU5IZoeuLknx6c42vwgzetwiQy06vwNmbVljm8gH6tTfqts+LjAp h7dee/0lAAolBJPpGiLFPwArkvPvXyW1NNHBZBlx57wwBYbs71QXRpC0ytiSLGAqqBCq 3u11ZWIChKp3n8SVZcLB/NrpUpQIMoS56ednrZRWgdx7rfa5ovgBj/9Ke5BDInrmWsxt INkD130eGxBRHAYgf20Imi4uoMgMDC4v8EEaklLnZhd8GKyMw2ys0TRrlCXvEFdl0BNm qDSw== X-Gm-Message-State: AOAM5338DVI5s17iTF8X54SJhJ2V7XUBwqclzZVrBhwYlkrWoWEEsr/A SVLM3m5A2r/8iXCl3Zh38tMZdQ== X-Google-Smtp-Source: ABdhPJwojhJ2jO+Hc+klRruTOm98kS9CL/R0u4elp0+vS8geZsyq/412gxGCq0Y/QKSQEu64XQ2pZA== X-Received: by 2002:ac8:7dc6:0:b0:2de:708:3e3a with SMTP id c6-20020ac87dc6000000b002de07083e3amr1026671qte.459.1646853500165; Wed, 09 Mar 2022 11:18:20 -0800 (PST) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id z6-20020ae9c106000000b0067d3b9ef387sm876005qki.28.2022.03.09.11.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 11:18:19 -0800 (PST) Date: Wed, 9 Mar 2022 14:18:19 -0500 From: Johannes Weiner To: cgel.zte@gmail.com Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, Yang Yang , Ran Xiaokai Subject: Re: [PATCH] block/psi: remove PSI annotations from submit_bio Message-ID: References: <20220309094323.2082884-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309094323.2082884-1-yang.yang29@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 09:43:24AM +0000, cgel.zte@gmail.com wrote: > From: Yang Yang > > psi tracks the time spent submitting the IO of refaulting pages[1]. > But after we tracks refault stalls from swap_readpage[2][3], there > is no need to do so anymore. Since swap_readpage already includes > IO submitting time. > > [1] commit b8e24a9300b0 ("block: annotate refault stalls from IO submission") > [2] commit 937790699be9 ("mm/page_io.c: annotate refault stalls from swap_readpage") > [3] commit 2b413a1a728f ("mm: page_io: fix psi memory pressure error on cold swapins") > > Signed-off-by: Yang Yang > Reviewed-by: Ran Xiaokai It's still needed by file cache refaults! NAK