From: Greg KH <gregkh@linuxfoundation.org>
To: Vishnu Dasa <vdasa@vmware.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
bryantan@vmware.com, rjalisatgi@vmware.com
Subject: Re: [PATCH] VMCI: Fix a couple of failure paths in vmci_guest_probe_device()
Date: Wed, 9 Mar 2022 19:33:10 +0100 [thread overview]
Message-ID: <Yijy5miaTI3GIXDZ@kroah.com> (raw)
In-Reply-To: <1646850296-49445-1-git-send-email-vdasa@vmware.com>
On Wed, Mar 09, 2022 at 10:24:56AM -0800, Vishnu Dasa wrote:
> notification_bitmap may not be released when VMCI_CAPS_DMA_DATAGRAM
> capability is missing from the device. Add missing
> 'err_free_notification_bitmap' label and use it instead of
> 'err_free_data_buffers' to avoid this.
>
> free_irq() may be called to free an interrupt that was not
> allocated. Add missing 'if' statement to check for
> exclusive_vectors when freeing interrupt 1.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Bryan Tan <bryantan@vmware.com>
> Reviewed-by: Rajesh Jalisatgi <rjalisatgi@vmware.com>
> Signed-off-by: Vishnu Dasa <vdasa@vmware.com>
> ---
> The patches which introduced these bugs are not in any released
> kernels nor RC yet, so this fix does not need to be backported.
So this has to get into 5.17-final? If not, it should be backported to
5.17, right? You should always include the "Fixes:" tag in the commit
message so that we can figure this out.
And shouldn't this be 2 different patches? Please break up.
thanks,
greg k-h
parent reply other threads:[~2022-03-10 9:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1646850296-49445-1-git-send-email-vdasa@vmware.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yijy5miaTI3GIXDZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bryantan@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rjalisatgi@vmware.com \
--cc=vdasa@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox