From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C21C433F5 for ; Wed, 9 Mar 2022 22:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238686AbiCIWdK (ORCPT ); Wed, 9 Mar 2022 17:33:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238771AbiCIWdF (ORCPT ); Wed, 9 Mar 2022 17:33:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A89C3120F75; Wed, 9 Mar 2022 14:32:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42D5C61BF2; Wed, 9 Mar 2022 22:32:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCA96C340E8; Wed, 9 Mar 2022 22:32:02 +0000 (UTC) Date: Wed, 9 Mar 2022 22:31:59 +0000 From: Catalin Marinas To: Nick Desaulniers Cc: Nathan Chancellor , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org, Marc Zyngier , James Morse Subject: Re: [PATCH] arm64: Do not include __READ_ONCE() block in assembly files Message-ID: References: <20220309191633.2307110-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 01:53:50PM -0800, Nick Desaulniers wrote: > On Wed, Mar 9, 2022 at 11:19 AM Nathan Chancellor wrote: > > Avoid this problem by just avoiding the CONFIG_LTO=y __READ_ONCE() block > > in asm/rwonce.h with assembly files, as nothing in that block is useful > > to assembly files, which allows ARM_SMCCC_ARCH_WORKAROUND_3 to be > > properly expanded with CONFIG_LTO=y builds. > > > > Cc: stable@vger.kernel.org > > Fixes: e35123d83ee3 ("arm64: lto: Strengthen READ_ONCE() to acquire when CONFIG_LTO=y") > > Link: https://lore.kernel.org/r/20220309155716.3988480-1-maz@kernel.org/ > > Reported-by: Marc Zyngier > > Acked-by: James Morse > > Signed-off-by: Nathan Chancellor > > Thanks for taking point on all of the BHB fallout. > > Reviewed-by: Nick Desaulniers > Tested-by: Nick Desaulniers Thanks for the review and testing. Unfortunately I've just sent the pull request to Linus, so didn't include your tags. -- Catalin