From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B1AC433EF for ; Thu, 10 Mar 2022 05:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239606AbiCJFtt (ORCPT ); Thu, 10 Mar 2022 00:49:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239755AbiCJFta (ORCPT ); Thu, 10 Mar 2022 00:49:30 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 819FEAE67 for ; Wed, 9 Mar 2022 21:48:25 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D7356210F3; Thu, 10 Mar 2022 05:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646891303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hzxTsvvzhK5KVT7xuWAwpPmOQv+KiG4w64eraMyiq1M=; b=Jl9lihcEIuiCASQMBi+6z96c+PhquyjWojHJ7ThcmaL668ZSQQZ0qRvPuTH7FcG6ogJ253 lElJQVY2kHYr3KcEIr0WMAWwqMtPegYQU646cw8W5W5mQIH0H6xG1V6YdeFpXMA8qGIbEM bB/4kRlQgUUSUVylyXsrZ9BXMjcEjRA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646891303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hzxTsvvzhK5KVT7xuWAwpPmOQv+KiG4w64eraMyiq1M=; b=DM+1Jv2UiUlEYLfpd6h8B+62AcnHcfJv2kVVEvHhVkNCKqefTvtFHZgaE5t/mnCBf2LV4Z tA1B5Kq2YlQTHfAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 07DBC13D07; Thu, 10 Mar 2022 05:48:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z+L2OSaRKWLbfAAAMHmgww (envelope-from ); Thu, 10 Mar 2022 05:48:22 +0000 Date: Thu, 10 Mar 2022 06:48:21 +0100 From: Oscar Salvador To: "Huang, Ying" Cc: Andrew Morton , Dave Hansen , Abhishek Goel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Message-ID: References: <20220309144644.4278-1-osalvador@suse.de> <87bkyefxnq.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bkyefxnq.fsf@yhuang6-desk2.ccr.corp.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2022 at 08:39:53AM +0800, Huang, Ying wrote: > We need to call set_migration_target_nodes() during system boot > somewhere, either here or in init_mm_internals(). Hi Huang Ying, vmstat_cpu_online() already gets called during boot: static struct cpuhp_step cpuhp_hp_states[] = { ... #ifdef CONFIG_SMP [CPUHP_CREATE_THREADS]= { .name = "threads:prepare", .startup.single = smpboot_create_threads, .teardown.single = NULL, .cant_stop = true, }, ... smpboot_create_threads __smpboot_create_thread smpboot_thread_fn ht->thread_fn() cpuhp_thread_fun cpuhp_invoke_callback vmstat_cpu_online That for every CPU that is brought up during boot. So unless I am missing something, I would say we are already covered there, right? -- Oscar Salvador SUSE Labs