From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB8BC433EF for ; Thu, 10 Mar 2022 12:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241978AbiCJM0T (ORCPT ); Thu, 10 Mar 2022 07:26:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237763AbiCJM0S (ORCPT ); Thu, 10 Mar 2022 07:26:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 980F663F4; Thu, 10 Mar 2022 04:25:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BA426191A; Thu, 10 Mar 2022 12:25:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3906C340E8; Thu, 10 Mar 2022 12:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646915116; bh=vcfAPDoZuzO8dkhCU5Hzdcr2BQ8q0N0ap2jBbaQyyLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v6jRM7Kk5NjMGYnB9QGFFeO3riCbdCt+1XM+OHvkksMt6f1SjgIgmEb38394wLZEm V37Y/Ts6BXso4gwuMlVgblnWv9fyWzcTBcrPKWFRcolL1r7/yqGdrtn5SBe4vBMQaR W5ZPRpmJaF+UjsJCBDqR9VTKBwlSJ2mQyWCYP1sk= Date: Thu, 10 Mar 2022 13:25:12 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: linux-kernel , Stable , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, lkft-triage@lists.linaro.org, Pavel Machek , Jonathan Hunter , Florian Fainelli , slade@sladewatkins.com Subject: Re: [PATCH 4.19 00/18] 4.19.234-rc1 review Message-ID: References: <20220309155856.155540075@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2022 at 09:51:12AM +0000, Sudip Mukherjee wrote: > On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Mar 09, 2022 at 06:08:19PM +0000, Sudip Mukherjee wrote: > > > Hi Greg, > > > > > > On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > This is the start of the stable review cycle for the 4.19.234 release. > > > > There are 18 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. > > > > Anything received after that time might be too late. > > > > > > My tests are still running, but just an initial result for you, > > > > > > x86_64 defconfig fails with: > > > arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': > > > arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of > > > function 'unprivileged_ebpf_enabled' > > > [-Werror=implicit-function-declaration] > > > 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled()) > > > > It's in a .h file, how can it be undefined? Must be a include path > > somewhere, let me dig... > > Looks like the problem is that both "static inline bool > unprivileged_ebpf_enabled(void)" are in the "#ifdef > CONFIG_BPF_SYSCALL" section of include/linux/bpf.h. > I think the one returning false should be in the #else section. Ah, good catch! I've fixed this up for 4.19 and 5.4 now, will do some build tests and then push out new -rc2 release for all branches as I think that should be all of the reported problems fixed. Now on to the next new round of build failures! :) thanks, greg k-h