From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, davem@davemloft.net,
kuba@kernel.org, david.laight@aculab.com
Subject: Re: [PATCH net-next v2] net: lan966x: Improve the CPU TX bitrate.
Date: Thu, 10 Mar 2022 15:36:23 +0100 [thread overview]
Message-ID: <YioM5zVqFtFxYhc+@lunn.ch> (raw)
In-Reply-To: <20220310084005.262551-1-horatiu.vultur@microchip.com>
On Thu, Mar 10, 2022 at 09:40:05AM +0100, Horatiu Vultur wrote:
> When doing manual injection of the frame, it is required to check if the
> TX FIFO is ready to accept the next word of the frame. For this we are
> using 'readx_poll_timeout_atomic', the only problem is that before it
> actually checks the status, is determining the time when to finish polling
> the status. Which seems to be an expensive operation.
> Therefore check the status of the TX FIFO before calling
> 'readx_poll_timeout_atomic'.
> Doing this will improve the TX bitrate by ~70%. Because 99% the FIFO is
> ready by that time. The measurements were done using iperf3.
>
> Before:
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.03 sec 55.2 MBytes 46.2 Mbits/sec 0 sender
> [ 5] 0.00-10.04 sec 53.8 MBytes 45.0 Mbits/sec receiver
>
> After:
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.10 sec 95.0 MBytes 78.9 Mbits/sec 0 sender
> [ 5] 0.00-10.11 sec 95.0 MBytes 78.8 Mbits/sec receiver
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-03-10 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 8:40 [PATCH net-next v2] net: lan966x: Improve the CPU TX bitrate Horatiu Vultur
2022-03-10 14:36 ` Andrew Lunn [this message]
2022-03-11 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YioM5zVqFtFxYhc+@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=david.laight@aculab.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox